From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 4/6] gitweb: Link to associated tree from a particular log item in full log view
Date: Sat, 23 Sep 2006 10:59:22 +0200 [thread overview]
Message-ID: <ef2t16$bcp$2@sea.gmane.org> (raw)
In-Reply-To: 7vodt7xvgu.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
>
>> Oops. It's trivial typo:
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index d2366c7..c5f3810 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -2880,7 +2880,7 @@ sub git_log {
>> " | " .
>> $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
>> " | " .
>> - $cgi->a({-href => href(action=>"tree", hash=>$commit), hash_base=>$commit}, "tree") .
>> + $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
>> "<br/>\n" .
>> "</div>\n" .
>> "<i>" . esc_html($co{'author_name'}) . " [$ad{'rfc2822'}]</i><br/>\n" .
>>
>>> You do not have the tree object name available in git_log to
>>> generate an URL with both h and hb, and getting to it is an
>>> extra work.
>>
>> Well using commit hash as a tree id works just fine...
>
> I agree that change is much safer. Will apply with an
> appropriate log message and attribution. No need to resend.
I think that hash_base without hash should be enough. But I'm not
sure if it is. Well, commit hash is tree-ish...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-09-23 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 1:19 [PATCH 1/6] gitweb: More per-view navigation bar links Petr Baudis
2006-09-22 1:19 ` [PATCH 2/6] gitweb: Link to tree instead of snapshot in shortlog Petr Baudis
2006-09-22 1:19 ` [PATCH 3/6] gitweb: Link to latest tree from the head line in heads list Petr Baudis
2006-09-22 1:19 ` [PATCH 4/6] gitweb: Link to associated tree from a particular log item in full log view Petr Baudis
2006-09-22 4:18 ` Junio C Hamano
2006-09-22 23:13 ` Petr Baudis
2006-09-23 0:44 ` Junio C Hamano
2006-09-23 8:59 ` Jakub Narebski [this message]
2006-09-22 1:19 ` [PATCH 5/6] gitweb: Rename "plain" labels to "raw" Petr Baudis
2006-09-22 9:04 ` Jakub Narebski
2006-09-22 23:09 ` Petr Baudis
2006-09-22 1:19 ` [PATCH 6/6] gitweb: Relabel "head" as "HEAD" Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ef2t16$bcp$2@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).