git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage
Date: Sat, 23 Sep 2006 21:54:40 +0200	[thread overview]
Message-ID: <ef43do$fm1$1@sea.gmane.org> (raw)
In-Reply-To: 7virjes7dq.fsf@assigned-by-dhcp.cox.net

Junio C Hamano wrote:

> -             "<a href=\"http://www.kernel.org/pub/software/scm/git/docs/\" title=\"git documentation\">" .
> +             "<a href=\"" . esc_html($githelp_url) .
> +             "\" title=\"" . esc_html($githelp_label) .
> +             "\">" .

Why not use $cgi->a_begin({-href=>esc_param($githelp_url), -title=>$githelp_label});
or just plain $cgi->a and $cgi->img?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  parent reply	other threads:[~2006-09-23 19:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-19 21:27 [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage Petr Baudis
2006-09-23 12:57 ` Petr Baudis
2006-09-23 19:36   ` Junio C Hamano
2006-09-23 19:46     ` Petr Baudis
2006-10-05 20:47       ` Petr Baudis
2006-10-05 21:23         ` Junio C Hamano
2006-10-05 21:34           ` Junio C Hamano
2006-10-05 23:57             ` Petr Baudis
2006-09-23 19:54     ` Jakub Narebski [this message]
2006-09-23 20:46       ` Junio C Hamano
2006-10-06 10:31         ` [PATCH] gitweb: Cleanup Git logo and Git logo target generation Jakub Narebski
2006-10-07  8:36           ` Junio C Hamano
2006-10-07  9:58             ` Jakub Narebski
2006-10-07 14:14               ` Alan Chandler
2006-10-08 13:31           ` Jakub Narebski
2006-10-08 19:47             ` Junio C Hamano
2006-10-08 20:10               ` Petr Baudis
2006-10-08 20:33                 ` Junio C Hamano
2006-10-08 20:54                   ` Jakub Narebski
2006-10-09  0:54                     ` Junio C Hamano
2006-10-09  7:14                       ` Jakub Narebski
2006-10-09  9:00                         ` Junio C Hamano
2006-10-09  9:26                           ` Jakub Narebski
2006-10-09 20:36                           ` Petr Baudis
2006-10-08 20:17               ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ef43do$fm1$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).