From: "Martin Ågren" <martin.agren@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 2/3] t9810: drop debug `cat` call
Date: Sun, 23 Feb 2020 09:48:35 +0100 [thread overview]
Message-ID: <ef45c9cabe7fe3f31d63edb872ba946ffbd951fe.1582447606.git.martin.agren@gmail.com> (raw)
In-Reply-To: <dde0f85e5e3dd99a61b83df1b6eb572be8a3ff51.1582447606.git.martin.agren@gmail.com>
We `cat` kwdelfile.c, but don't inspect or grab the contents in any way.
This looks like a remnant from a debug session. Similar to the previous
commit, one could argue that `cat`-ing the file verifies that it didn't
disappear somehow. But because the very next thing we do after `cat`-ing
the file is to `grep` in it, we can safely drop the call to `cat`.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
t/t9810-git-p4-rcs.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/t9810-git-p4-rcs.sh b/t/t9810-git-p4-rcs.sh
index 57b533dc6f..e3836888ec 100755
--- a/t/t9810-git-p4-rcs.sh
+++ b/t/t9810-git-p4-rcs.sh
@@ -294,7 +294,6 @@ test_expect_success 'cope with rcs keyword file deletion' '
echo "\$Revision\$" >kwdelfile.c &&
p4 add -t ktext kwdelfile.c &&
p4 submit -d "Add file to be deleted" &&
- cat kwdelfile.c &&
grep 1 kwdelfile.c
) &&
git p4 clone --dest="$git" //depot &&
--
2.25.0
next prev parent reply other threads:[~2020-02-23 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 8:48 [PATCH 1/3] t4117: check for files using `test_path_is_file` Martin Ågren
2020-02-23 8:48 ` Martin Ågren [this message]
2020-02-24 19:18 ` [PATCH 2/3] t9810: drop debug `cat` call Junio C Hamano
2020-02-23 8:48 ` [PATCH 3/3] t: drop debug `cat` calls Martin Ågren
2020-02-24 19:32 ` Junio C Hamano
2020-02-24 20:24 ` Martin Ågren
2020-02-24 20:49 ` Junio C Hamano
2020-02-23 21:46 ` [PATCH 1/3] t4117: check for files using `test_path_is_file` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef45c9cabe7fe3f31d63edb872ba946ffbd951fe.1582447606.git.martin.agren@gmail.com \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).