git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC/PATCH] gitweb: Add committags support
Date: Sun, 24 Sep 2006 11:37:45 +0200	[thread overview]
Message-ID: <ef5jkv$gep$1@sea.gmane.org> (raw)
In-Reply-To: 7v4puys3ye.fsf@assigned-by-dhcp.cox.net

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> The idea of doing committag parsing, and preserving replacements
>> from matching committag and being subject to HTML escaping by using
>> reference to string has it's merits.
>>
>> I'd have to think about it.
> 
> Good.  My obviously buggy illustration would be easier to read
> with this patch ;-).

Don't forget about final s,\n,<br/>\n,gm if we parse it as a whole,
and not line by line. 

By the way, I think that only the driver (i.e. format_log_line_html) has to
be changed...
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2006-09-24  9:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 21:56 [RFC/PATCH] gitweb: Add committags support Jakub Narebski
2006-09-22 17:55 ` Jakub Narebski
2006-09-23  3:29 ` Petr Baudis
2006-09-23  8:34   ` Jakub Narebski
2006-09-23 12:11     ` Petr Baudis
2006-09-23 13:33       ` Jakub Narebski
2006-09-23 14:05         ` Petr Baudis
2006-09-25 18:06           ` Jakub Narebski
2006-09-25 20:15             ` Petr Baudis
2006-09-26 11:52               ` Jakub Narebski
2006-09-23 19:58       ` Junio C Hamano
2006-09-23 20:18         ` Jakub Narebski
2006-09-23 20:50           ` Junio C Hamano
2006-09-24  9:37             ` Jakub Narebski [this message]
2006-09-24 10:34               ` Junio C Hamano
2006-09-24 16:35               ` Jakub Narebski
2006-09-24 19:17                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ef5jkv$gep$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).