From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [RFC/PATCH] gitweb: Add committags support Date: Sun, 24 Sep 2006 18:35:26 +0200 Organization: At home Message-ID: References: <200609212356.31806.jnareb@gmail.com> <20060923032948.GE8259@pasky.or.cz> <200609231034.49545.jnareb@gmail.com> <20060923121134.GM13132@pasky.or.cz> <7veju2s6bi.fsf@assigned-by-dhcp.cox.net> <7v4puys3ye.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: QUOTED-PRINTABLE X-From: git-owner@vger.kernel.org Sun Sep 24 18:36:00 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GRWxK-0003sH-93 for gcvg-git@gmane.org; Sun, 24 Sep 2006 18:35:51 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbWIXQfo convert rfc822-to-quoted-printable (ORCPT ); Sun, 24 Sep 2006 12:35:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751217AbWIXQfo (ORCPT ); Sun, 24 Sep 2006 12:35:44 -0400 Received: from main.gmane.org ([80.91.229.2]:21485 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S1751209AbWIXQfn (ORCPT ); Sun, 24 Sep 2006 12:35:43 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GRWx2-0003or-UZ for git@vger.kernel.org; Sun, 24 Sep 2006 18:35:32 +0200 Received: from host-81-190-26-109.torun.mm.pl ([81.190.26.109]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 24 Sep 2006 18:35:32 +0200 Received: from jnareb by host-81-190-26-109.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 24 Sep 2006 18:35:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-26-109.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Jakub Narebski wrote: > Junio C Hamano wrote: >=20 >> Jakub Narebski writes: >>=20 >>> The idea of doing committag parsing, and preserving replacements >>> from matching committag and being subject to HTML escaping by using >>> reference to string has it's merits. >>> >>> I'd have to think about it. >>=20 >> Good. =A0My obviously buggy illustration would be easier to read >> with this patch ;-). >=20 > Don't forget about final s,\n,
\n,gm if we parse it as a whole, > and not line by line.=20 >=20 > By the way, I think that only the driver (i.e. format_log_line_html) = has to > be changed... Yet another question is how to deal with commit message specific "syntax highlighting". Currently, parsing commit message line by line, we treat specially signoff lines (syntax highlighting, and removing trailing empty lines after signoff), empty lines (we collapse consecuti= ve empty lines); the rest goes through format_log_line_html... and committ= ags. Tag messages have another specific syntax highlighting, namely PGP/GPG signature part, which should be syntax highlighted I think (and not=20 subject to committags replacements). Some of the problems of marking replacements as not to be committags=20 searched and not to be HTML escaped can be dealt with by changing the order of committags. For example having 'URL' tag as first tag to check we avoid invoking it on committag replacements links. --=20 Jakub Narebski Warsaw, Poland ShadeHawk on #git