git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC/PATCH] gitweb: Add committags support
Date: Mon, 25 Sep 2006 20:06:44 +0200	[thread overview]
Message-ID: <ef95rk$o4q$1@sea.gmane.org> (raw)
In-Reply-To: 20060923140535.GK8259@pasky.or.cz

Petr Baudis wrote:

> Dear diary, on Sat, Sep 23, 2006 at 03:33:01PM CEST, I got a letter
> where Jakub Narebski <jnareb@gmail.com> said that...
>> Petr Baudis wrote:
>> 
>> > Dear diary, on Sat, Sep 23, 2006 at 10:34:49AM CEST, I got a letter
>> > where Jakub Narebski <jnareb@gmail.com> said that...
>> 
>> > Also, there is a fundamental limitation for the multi-word patterns that
>> > they won't work if the line wraps at that point in the log message. This
>> > will likely be a problem especially for the msgids, because those are
>> > very long and are very likely to cause a linewrap immediately before.
>> 
>> We do not wrap log messages in gitweb. So the problem is only when
>> commit message is wrongly wrapped itself (pre imples nowrap).
> 
> The commit message is not "wrongly" wrapped but just wrapped to fit into
> 72 or whatever columns. It would be silly to mandate users to use msg-id: <200609231533.02455.jnareb@gmail.com>
> with the message id stretching far away just for the sake of some
> gitweb limitations when having the message wrapped such as msg-id:
> <200609231533.02455.jnareb@gmail.com> looks much more reasonable.

So when putting message if into commit message, just put the commit
message in separate line, perhaps even with some indentation, like
below:
  Msg-Id: <200609231533.02455.jnareb@gmail.com>

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2006-09-25 18:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 21:56 [RFC/PATCH] gitweb: Add committags support Jakub Narebski
2006-09-22 17:55 ` Jakub Narebski
2006-09-23  3:29 ` Petr Baudis
2006-09-23  8:34   ` Jakub Narebski
2006-09-23 12:11     ` Petr Baudis
2006-09-23 13:33       ` Jakub Narebski
2006-09-23 14:05         ` Petr Baudis
2006-09-25 18:06           ` Jakub Narebski [this message]
2006-09-25 20:15             ` Petr Baudis
2006-09-26 11:52               ` Jakub Narebski
2006-09-23 19:58       ` Junio C Hamano
2006-09-23 20:18         ` Jakub Narebski
2006-09-23 20:50           ` Junio C Hamano
2006-09-24  9:37             ` Jakub Narebski
2006-09-24 10:34               ` Junio C Hamano
2006-09-24 16:35               ` Jakub Narebski
2006-09-24 19:17                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ef95rk$o4q$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).