From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: tree view: eliminate redundant "blob"
Date: Tue, 26 Sep 2006 10:54:49 +0200 [thread overview]
Message-ID: <efapsl$e65$1@sea.gmane.org> (raw)
In-Reply-To: 20060926053816.54951.qmail@web31815.mail.mud.yahoo.com
Luben Tuikov wrote:
> Binary and non-binary blobs:
>
> The "list" table element of tree view is identical
> to the "blob" link part of the link table element.
> I.e. clicking on "blob" is identical to clicking on
> the entry itself.
>
> Thus, eliminate "blob" from being shown -- the user
> can get identical result by simply clicking on the
> entry itself.
I'd rather not. The fact that the file name and tree name is link,
and the fact that commit title and tag title is link is a _convenience_.
Not always it is visible (without mouseover) that it is link.
And it is _not_ visible in the case of files!
And for example for commits and heads there are two possible
views, commit and commitdiff for commit, shortlog and log for head,
of which we arbitrary chose one for the subject link. So in that
case the additional self link is needed. I'd rather have both.
And for consistency I'd rather always have visible form default
self link/
I'd rather have additional link, than cause confusion to the users.
Perhaps we could separate the self link ("blob" for files, "tree"
for directories) into separate column?
Besides, you have to mouse over the name of file, or name of
directory to see to what view it would lead on.
Nak.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-09-26 8:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 5:38 [PATCH] gitweb: tree view: eliminate redundant "blob" Luben Tuikov
2006-09-26 6:34 ` Junio C Hamano
2006-09-26 17:04 ` Luben Tuikov
2006-09-26 8:54 ` Jakub Narebski [this message]
2006-09-26 9:22 ` Jakub Narebski
2006-09-26 16:07 ` Petr Baudis
2006-09-26 16:24 ` Jakub Narebski
2006-09-26 20:33 ` Luben Tuikov
2006-09-27 2:40 ` Junio C Hamano
2006-10-01 18:49 ` Jakub Narebski
2006-09-26 20:14 ` Luben Tuikov
2006-09-26 20:31 ` Jakub Narebski
2006-09-26 21:32 ` Luben Tuikov
2006-09-26 22:24 ` Jakub Narebski
2006-09-26 22:30 ` Jakub Narebski
2006-09-27 6:42 ` Junio C Hamano
2006-10-01 18:41 ` Jakub Narebski
2006-10-01 18:56 ` Junio C Hamano
2006-10-01 19:27 ` Jakub Narebski
2006-10-02 7:15 ` Andreas Ericsson
2006-10-02 10:56 ` Jakub Narebski
2006-10-02 7:34 ` Junio C Hamano
2006-10-02 11:06 ` Jakub Narebski
2006-10-02 19:46 ` Luben Tuikov
2006-10-02 19:11 ` Luben Tuikov
2006-10-02 20:03 ` Jakub Narebski
2006-10-03 4:14 ` Junio C Hamano
2006-10-03 8:18 ` Jakub Narebski
2006-10-03 9:34 ` Junio C Hamano
2006-10-03 10:15 ` Jakub Narebski
2006-10-05 0:15 ` Luben Tuikov
2006-10-03 20:20 ` Luben Tuikov
2006-10-03 16:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='efapsl$e65$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).