From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: gitweb: using quotemeta
Date: Mon, 02 Oct 2006 02:28:14 +0200 [thread overview]
Message-ID: <efpme9$o13$1@sea.gmane.org> (raw)
In-Reply-To: 20060928232752.99373.qmail@web31804.mail.mud.yahoo.com
Luben Tuikov wrote:
> --- Junio C Hamano <junkio@cox.net> wrote:
>>
>> Ouch, that was a sloppy planning and coding, and sloppier
>> reviewing. Sorry.
>>
>> What is the right quoting there? Just quoting double-quotes?
>
> I'm not sure. What undesired character could we have in $filename
> of a snapshot? The commit ab41dfbfd4f message gives this
> justification: "Just in case filename contains end of line character."
>
> It looks like $filename is constructed by well defined strings:
> basename($project), $hash and $suffix all of which should be ok.
>
> I'd say we don't need quotemeta for $filename of snapshot.
But we do need quoting for blob_plain and perhaps blobdiff_plain
views, although not quotemeta, but perhaps the reverse of unescape,
i.e. quote '"', EOLN (end of line) and perhaps also TAB.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-02 0:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 21:15 gitweb: using quotemeta Luben Tuikov
2006-09-28 23:18 ` Junio C Hamano
2006-09-28 23:27 ` Luben Tuikov
2006-10-02 0:28 ` Jakub Narebski [this message]
2006-10-02 20:12 ` Luben Tuikov
2006-10-02 20:50 ` Jakub Narebski
2006-10-03 6:30 ` Junio C Hamano
2006-10-06 12:38 ` Jakub Narebski
2006-10-07 5:08 ` Junio C Hamano
2006-10-07 9:23 ` Jakub Narebski
2006-10-07 17:41 ` Luben Tuikov
2006-10-11 9:48 ` Jakub Narebski
2006-10-06 13:50 ` Petr Baudis
2006-10-06 18:21 ` Luben Tuikov
2006-10-06 18:45 ` Petr Baudis
-- strict thread matches above, loose matches on Subject: below --
2006-10-06 18:24 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='efpme9$o13$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).