From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Remove redundant "commit" link from shortlog
Date: Fri, 06 Oct 2006 17:08:43 +0200 [thread overview]
Message-ID: <eg5rgf$58c$2@sea.gmane.org> (raw)
In-Reply-To: 20061006135508.GO20017@pasky.or.cz
Petr Baudis wrote:
> Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter
> where Luben Tuikov <ltuikov@yahoo.com> said that...
>> Remove the redundant "commit" link from shortlog.
>> It can be had by simply clicking on the entry title
>> of the row.
>>
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
>
> And what if the commit message is empty?
>
> Witness at http://repo.or.cz/?p=test;a=summary
By the way, commitdiff view in this case also looks strange.
I think that simplyfying the git_difftree_body went too far,
Luben.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-06 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 23:48 [PATCH] gitweb: Remove redundant "commit" link from shortlog Luben Tuikov
2006-10-06 13:55 ` Petr Baudis
2006-10-06 15:08 ` Jakub Narebski [this message]
2006-10-06 16:55 ` [PATCH] gitweb: Handle commits with empty commit messages more reasonably Petr Baudis
2006-10-06 18:27 ` [PATCH] gitweb: Remove redundant "commit" link from shortlog Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eg5rgf$58c$2@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).