From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Convert Content-Disposition filenames into qtext
Date: Sat, 07 Oct 2006 12:06:31 +0200 [thread overview]
Message-ID: <eg7u5n$mt9$1@sea.gmane.org> (raw)
In-Reply-To: 7vk63ctq47.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
>
>>>> +# Convert a string (e.g. a filename) into qtext as defined
>>>> +# in RFC 822, from RFC 2183. To be used by Content-Disposition.
>>>> +sub to_qtext {
>>>> + my $str = shift;
>>>> + $str =~ s/\\/\\\\/g;
>>>> + $str =~ s/\"/\\\"/g;
Here probably it could be
$str =~ s/"/\\"/g;
>>>> + $str =~ s/\r/\\r/g;
>>>
>>> \r? Not \n?
>>
>> Yes, \r, not \n.
>
> \r to \\r? Not to \\\r?
We want "\r" in suggested filename, not "\
" I think, so it is "\\r".
Otherwise we could use simplier
$str =~ s/([\\"\r])/\\\1/g;
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-07 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 19:18 [PATCH] gitweb: Convert Content-Disposition filenames into qtext Luben Tuikov
2006-10-06 19:20 ` Petr Baudis
2006-10-06 19:30 ` Luben Tuikov
2006-10-07 9:46 ` Junio C Hamano
2006-10-07 10:06 ` Jakub Narebski [this message]
2006-10-07 10:34 ` Junio C Hamano
2006-10-07 18:01 ` Luben Tuikov
2006-10-07 11:46 ` Petr Baudis
2006-10-07 12:11 ` Jakub Narebski
2006-10-07 9:05 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eg7u5n$mt9$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).