From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: bug-gnu-utils@gnu.org
Subject: Re: [PATCH] Don't use $author_name undefined when $from contains no /\s</.
Date: Fri, 20 Oct 2006 17:48:21 +0200 [thread overview]
Message-ID: <ehar3v$e73$1@sea.gmane.org> (raw)
In-Reply-To: 87pscnj29t.fsf@penguin.cs.ucla.edu
Paul Eggert wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
>> If "trailing space" highlighting picks up the first column blank
>> in "diff -u" output, that highlighting feature is *broken*.
>
> If the buffer contains arbitrary text, some of which is diff -u output
> and some of which is not, then it it isn't possible in general for the
> highlighting mode to distinguish between the diff -u part and the
> other part.
Not true. If GNU patch (and git-apply) can detect where diff begins,
and can detect if diff was truncated, then highlighting mode can
distinguish between diff -u part and rest... well, unless you intermix
diff-u output and arbitrary text (so the patch would not apply, but what
happens when commenting a patch).
Still I'd rather relax highlighting code to not highlight "SPC LF"
than to change diff -u format.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
prev parent reply other threads:[~2006-10-20 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 8:33 [PATCH] Don't use $author_name undefined when $from contains no /\s</ Jim Meyering
2006-10-19 16:19 ` Junio C Hamano
2006-10-19 18:16 ` Jim Meyering
2006-10-19 19:03 ` Junio C Hamano
2006-10-19 21:28 ` Paul Eggert
2006-10-19 21:34 ` Junio C Hamano
2006-10-19 23:48 ` Paul Eggert
2006-10-20 7:52 ` Junio C Hamano
2006-10-20 16:21 ` Linus Torvalds
2006-10-20 15:48 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ehar3v$e73$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=bug-gnu-utils@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).