From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Make search type a popup menu
Date: Tue, 24 Oct 2006 09:33:12 +0200 [thread overview]
Message-ID: <ehkfis$6da$1@sea.gmane.org> (raw)
In-Reply-To: 20061024031546.2877.51620.stgit@rover
Petr Baudis wrote:
> This makes the multiple search types actually usable by the user;
> if you don't read the gitweb source, you don't even have an idea
> that you can write things like that there.
This is I think good change, although I'm not sure if I like changing
using search operators to using additional CGI parameter.
Having help page for search is _certainly_ very good change. Perhaps
we should put it out-of-line, not embedded? Just a thought...
This patch changes search box into something similar to Google
"Advanced Search". Yet Google "Advanced Search" box generates search
query using search operators. Search operators are just more powerfull.
I know that gitweb doesn't use this power now (it uses only one operator,
first if I remember correctly), but we can do this in the future
(e.g. searching for both author and specified string in commit message,
or searching for given author OR given committer). Well, we can always
change it back...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-24 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 3:15 [PATCH] gitweb: Make search type a popup menu Petr Baudis
2006-10-24 7:33 ` Jakub Narebski [this message]
2006-10-24 11:27 ` Petr Baudis
-- strict thread matches above, loose matches on Subject: below --
2006-10-11 20:58 Petr Baudis
2006-10-11 21:15 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ehkfis$6da$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).