From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] xdiff: Do not consider lines starting by # hunkworthy
Date: Wed, 25 Oct 2006 02:17:20 +0200 [thread overview]
Message-ID: <ehmadg$rkj$1@sea.gmane.org> (raw)
In-Reply-To: 20061025000708.2753.74523.stgit@machine.or.cz
Petr Baudis wrote:
> - *rec == '(' || /* lisp defun? */
> - *rec == '#')) { /* #define? */
> + *rec == '(')) { /* #define? */
> if (len > sz)
Shouldn't it be:
+ *rec == '(')) { /* lisp defun? */
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
prev parent reply other threads:[~2006-10-25 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 0:07 [PATCH] xdiff: Do not consider lines starting by # hunkworthy Petr Baudis
2006-10-25 0:16 ` Junio C Hamano
2006-10-25 0:28 ` [PATCH] xdiff: Match GNU diff behaviour when deciding hunk comment worthiness of lines Petr Baudis
2006-10-25 1:33 ` Horst H. von Brand
2006-10-25 2:18 ` Junio C Hamano
2006-10-25 0:17 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ehmadg$rkj$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).