git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: git-shortlog mailmap
Date: Thu, 26 Oct 2006 15:13:40 +0200	[thread overview]
Message-ID: <ehqc8r$2nc$1@sea.gmane.org> (raw)
In-Reply-To: 4540AD6E.6070201@op5.se

Andreas Ericsson wrote:

> Jakub Narebski wrote:
>> Petr Baudis wrote:
>>>
>>> Dear diary, on Thu, Oct 26, 2006 at 11:25:50AM CEST, I got a letter
>>> where Jakub Narebski <jnareb@gmail.com> said that...
>>>>
>>>> BTW. both Perl version and builtin shorlog have email->real name translation
>>>> table built in. In Perl script version it is in __DATA__ section, and we
>>>> could update it using Inline::Files module, in C version it was in table.
>>>> But in fact this list is project specific. Shouldn't we make it customizable
>>>> (::sigh::, yet another file in $GIT_DIR...).
>>>>
>>> I really dislike the fact that we _do_ this mapping at all, this seems
>>> so much a totally wrong point at which to do it. The information tracked
>>> in Git is still wrong and all the tools except shortlog still display it
>>> wrong - why should shortlog in particular be special? Why don't we do
>>> this at the git-am time instead?
>> 
>> Because git-shortlog has to deal also with _historical_ data, which caused
>> one way or the other to have only email and not realname recorded. So till
>> history gets rewritteen, and tags resigned, git-shortlog has to do the
>> mapping to have meaningfull output.
> 
> Wouldn't this be better implemented in the rev-list code then, so all 
> log viewers can benefit from it?

Because this belongs to porcelain. Plumbing shouldn't show something
that isn't there.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git


  reply	other threads:[~2006-10-26 13:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-26  8:47 What's in git.git Junio C Hamano
2006-10-26  9:12 ` Jakub Narebski
2006-10-26  9:24   ` Junio C Hamano
2006-10-26 12:08   ` Petr Baudis
2006-10-26 12:17     ` Jakub Narebski
2006-10-26  9:18 ` merge-recursive, was " Johannes Schindelin
2006-10-26  9:25   ` Jakub Narebski
2006-10-26  9:35     ` Junio C Hamano
2006-10-26  9:47       ` Jakub Narebski
2006-10-26 13:23       ` Nicolas Pitre
2006-10-26 12:34     ` git-shortlog mailmap Petr Baudis
2006-10-26 12:41       ` Jakub Narebski
2006-10-26 12:43         ` Andreas Ericsson
2006-10-26 13:13           ` Jakub Narebski [this message]
2006-10-26 13:16             ` Johannes Schindelin
2006-10-26 13:29         ` Petr Baudis
2006-10-26  9:26   ` merge-recursive, was Re: What's in git.git Junio C Hamano
2006-10-26 10:00     ` Junio C Hamano
2006-10-26 10:56       ` Johannes Schindelin
2006-10-26 11:35   ` shortlog, was " Andreas Ericsson
2006-10-26 13:39     ` Nicolas Pitre
2006-10-26 13:45       ` Andreas Ericsson
2006-10-26  9:19 ` Jakub Narebski
2006-10-27  1:10   ` Petr Baudis
2006-10-26 12:22 ` Petr Baudis
2006-10-26 17:27 ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ehqc8r$2nc$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).