From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Jakub Narebski Subject: Re: git-shortlog mailmap Date: Thu, 26 Oct 2006 15:13:40 +0200 Organization: At home Message-ID: References: <7vk62npipb.fsf@assigned-by-dhcp.cox.net> <20061026123424.GQ20017@pasky.or.cz> <4540AD6E.6070201@op5.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit NNTP-Posting-Date: Thu, 26 Oct 2006 13:14:11 +0000 (UTC) Return-path: Envelope-to: gcvg-git@gmane.org X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 36 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-23-110.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gd53D-0005NE-K7 for gcvg-git@gmane.org; Thu, 26 Oct 2006 15:13:39 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423498AbWJZNNf (ORCPT ); Thu, 26 Oct 2006 09:13:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423499AbWJZNNf (ORCPT ); Thu, 26 Oct 2006 09:13:35 -0400 Received: from main.gmane.org ([80.91.229.2]:21715 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S1423498AbWJZNNe (ORCPT ); Thu, 26 Oct 2006 09:13:34 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Gd52y-0005Ka-1W for git@vger.kernel.org; Thu, 26 Oct 2006 15:13:24 +0200 Received: from host-81-190-23-110.torun.mm.pl ([81.190.23.110]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Oct 2006 15:13:24 +0200 Received: from jnareb by host-81-190-23-110.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Oct 2006 15:13:24 +0200 To: git@vger.kernel.org Sender: git-owner@vger.kernel.org Andreas Ericsson wrote: > Jakub Narebski wrote: >> Petr Baudis wrote: >>> >>> Dear diary, on Thu, Oct 26, 2006 at 11:25:50AM CEST, I got a letter >>> where Jakub Narebski said that... >>>> >>>> BTW. both Perl version and builtin shorlog have email->real name translation >>>> table built in. In Perl script version it is in __DATA__ section, and we >>>> could update it using Inline::Files module, in C version it was in table. >>>> But in fact this list is project specific. Shouldn't we make it customizable >>>> (::sigh::, yet another file in $GIT_DIR...). >>>> >>> I really dislike the fact that we _do_ this mapping at all, this seems >>> so much a totally wrong point at which to do it. The information tracked >>> in Git is still wrong and all the tools except shortlog still display it >>> wrong - why should shortlog in particular be special? Why don't we do >>> this at the git-am time instead? >> >> Because git-shortlog has to deal also with _historical_ data, which caused >> one way or the other to have only email and not realname recorded. So till >> history gets rewritteen, and tags resigned, git-shortlog has to do the >> mapping to have meaningfull output. > > Wouldn't this be better implemented in the rev-list code then, so all > log viewers can benefit from it? Because this belongs to porcelain. Plumbing shouldn't show something that isn't there. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git