From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Remove extra "/" in path names for git_get_project_list
Date: Fri, 03 Nov 2006 12:18:00 +0100 [thread overview]
Message-ID: <eif8gd$6u5$1@sea.gmane.org> (raw)
In-Reply-To: 7vslh1jcji.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> "Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
>
>> Without this change we get a wrong $pfxlen value and the check_export_ok()
>> checks with with a wrong directory name. Without this patch the below
>> $projects_list fails with gitweb
>>
>> $projects_list = "/tmp/a/b/";
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>
>
> Hmph. Doesn't this break $projects_list = "/", I wonder?
>
>> + # remove the trailing "/"
>> + $dir =~ s!/+$!!;
So perhaps
$dir =~ s!(?<=[^/])/+$!!;
(zero-width positive look-behind assertion).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
prev parent reply other threads:[~2006-11-03 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 5:11 [PATCH] gitweb: Remove extra "/" in path names for git_get_project_list Aneesh Kumar K.V
2006-11-03 5:59 ` Junio C Hamano
2006-11-03 11:18 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eif8gd$6u5$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).