From: Anand Kumria <wildfire@progsoc.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.
Date: Sat, 25 Nov 2006 17:22:25 +0000 (UTC) [thread overview]
Message-ID: <ek9u4f$vmk$1@sea.gmane.org> (raw)
In-Reply-To: 87slg8uc0l.fsf@wine.dyndns.org
On Fri, 24 Nov 2006 15:58:50 +0100, Alexandre Julliard wrote:
> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
> ---
> shallow.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/shallow.c b/shallow.c
> index 2db1dc4..3d53d17 100644
> --- a/shallow.c
> +++ b/shallow.c
> @@ -60,7 +60,9 @@ struct commit_list *get_shallow_commits(
> commit = NULL;
> continue;
> }
> - commit->util = xcalloc(1, sizeof(int));
> + if (!commit->util)
> + commit->util = xmalloc(sizeof(int));
> + *(int *)commit->util = 0;
> cur_depth = 0;
Hi,
Any reason you didn't do:
if (!commit->util)
commit->util = xcalloc(1, sizeof(int));
That would seem to be the same.
Regards,
Anand
next prev parent reply other threads:[~2006-11-25 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 14:58 [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already Alexandre Julliard
2006-11-25 17:22 ` Anand Kumria [this message]
2006-11-25 18:49 ` Johannes Schindelin
2006-11-25 19:44 ` Junio C Hamano
2006-11-25 23:36 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ek9u4f$vmk$1@sea.gmane.org' \
--to=wildfire@progsoc.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).