git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tim Jaacks" <timjaacks@posteo.de>
To: "Jeff King" <peff@peff.net>, "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Bash completion for git aliases containing nested subcommands
Date: Tue, 04 Oct 2022 11:21:11 +0000	[thread overview]
Message-ID: <em34822e40-c62f-43aa-bc9b-2a87e9033ee8@acer-switch-tim> (raw)
In-Reply-To: <YzthDLdqeQx6bEcj@coredump.intra.peff.net>

Hi Peff,

thanks a lot for your reply.

 > It feels like this ought to be able to work, for the same reason that
 > "git stash show <TAB>" works. In the non-aliased case, we call into
 > _git_stash(), and it sees that "show" is already there on the command
 > line. But in the aliased case, we know "show" is part of the alias but
 > throw away that information completely, and never feed it to
 > _git_stash() at all.

I actually got the same impression when looking into the 
__git_aliased_command implementation. I just wasn't familiar enough with 
the code to actually come up with a solution. So thanks for your patch, 
that makes my use-case work indeed! Do you think there's a chance to get 
this upstream?

Best wishes,
Tim


  reply	other threads:[~2022-10-04 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 11:45 Bash completion for git aliases containing nested subcommands Tim Jaacks
2022-10-03 14:24 ` SZEDER Gábor
     [not found]   ` <1839e62f930.285a.8a94aeaa49923dfb9a7d55a303990d0a@posteo.de>
2022-10-03 15:11     ` Tim Jaacks
2022-10-03 15:43     ` SZEDER Gábor
2022-10-03 22:24   ` Jeff King
2022-10-04 11:21     ` Tim Jaacks [this message]
2022-10-05 10:05     ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=em34822e40-c62f-43aa-bc9b-2a87e9033ee8@acer-switch-tim \
    --to=timjaacks@posteo.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).