From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC] Possible optimization for gitweb
Date: Tue, 19 Dec 2006 23:22:25 +0100 [thread overview]
Message-ID: <em9oi5$72t$1@sea.gmane.org> (raw)
In-Reply-To: 7v1wmvpmef.fsf@assigned-by-dhcp.cox.net
[Please Cc: git@vger.kernel.org]
Junio C Hamano wrote:
> Robert Fitzsimons <robfitz@273k.net> writes:
>
>> The new workflows I'm proposing would be:
>> get/parse ~100 commit's using rev-list
>> foreach commit
>> output commit
>
> Absolutely.
>
> And Ok on rev-list part, but perhaps --skip would be more
> appropriate name.
The only problem that you can't use --parents with "history" view, because
together with --full-history it shows also all merges (--full-history
without --parents doesn't show merges which does not affect given file or
directory; the sequence in which --parents and --full-history are taken is
a bit strange to me). So you have to keep current parse_commit (or extend
it), and if I remember correctly you do that.
I'm also for --skip (not --start-count), although... --start-count with
--max-count seems more natural; one place it can be confusing is that we
count skipped commits or not? I.e. we use --start-count=10 --max-count=20
to get second 10 of commits, or --skip=10 --max-count=10 to get second 10
of commits?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-12-19 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 20:54 [RFC] Possible optimization for gitweb Robert Fitzsimons
2006-12-19 21:45 ` Jakub Narebski
2006-12-20 0:52 ` Robert Fitzsimons
2006-12-19 22:10 ` Junio C Hamano
2006-12-19 22:22 ` Jakub Narebski [this message]
2006-12-20 0:29 ` [PATCH] rev-list: Add a new option --skip Robert Fitzsimons
2006-12-20 1:09 ` Junio C Hamano
2006-12-20 14:59 ` [PATCH] rev-list: Document --skip and add test cases Robert Fitzsimons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='em9oi5$72t$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).