git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SungHyun Nam <goweol@gmail.com>
To: git@vger.kernel.org
Subject: Patch  (Re: t1300-repo-config.sh failed on CYGWIN)
Date: Wed, 20 Dec 2006 12:22:12 +0900	[thread overview]
Message-ID: <emaa94$qn4$1@sea.gmane.org> (raw)
In-Reply-To: <4588A1EC.7040301@gmail.com>

SungHyun Nam wrote:
> If I run it on CYGWIN, there's an error msg:
>
> * FAIL 39: rename section
>         git-repo-config --rename-section branch.eins branch.zwei
> * FAIL 40: rename succeeded
>         diff -u expect .git/config

With a patch below, the problem gone.

BTW, there's a leak for 'config_filename' in
git_config_rename_section().

Thanks,
namsh

diff --git a/config.c b/config.c
index 663993f..a23ac47 100644
--- a/config.c
+++ b/config.c
@@ -806,6 +806,7 @@ int git_config_rename_section(const char *old_name,
const char *new_name)
 		}
 		write(out_fd, buf, strlen(buf));
 	}
+	fclose(config_file);
 	if (close(out_fd) || commit_lock_file(lock) < 0)
 		return error("Cannot commit config file!");
 	return ret;

      reply	other threads:[~2006-12-20  3:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20  2:37 t1300-repo-config.sh failed on CYGWIN SungHyun Nam
2006-12-20  3:22 ` SungHyun Nam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='emaa94$qn4$1@sea.gmane.org' \
    --to=goweol@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).