git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] fix vc git
Date: Thu, 21 Dec 2006 12:32:16 +0100	[thread overview]
Message-ID: <emdr6v$9ma$1@sea.gmane.org> (raw)
In-Reply-To: 8e745ecf0612210325m72a569d7k370dd5953ccf6f27@mail.gmail.com

Duncan Mak wrote:

> -      (when dir (cd dir))
> +      (if (file-exists-p dir) (cd dir))

Adding `file-exist-p' is good, but there is no need to change
`when' to `if'.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2006-12-21 11:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-21 11:25 [PATCH] fix vc git Duncan Mak
2006-12-21 11:32 ` Jakub Narebski [this message]
2006-12-21 11:59   ` Duncan Mak
2006-12-22  0:52     ` Junio C Hamano
2006-12-22  4:11       ` Duncan Mak
2006-12-22  4:54         ` Junio C Hamano
2006-12-22 12:39         ` Alexandre Julliard
2006-12-22 12:51           ` Duncan Mak
2006-12-22 13:56             ` Alexandre Julliard
2006-12-22 15:17               ` Duncan Mak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='emdr6v$9ma$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).