From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Sanitize for_each_reflog_ent()
Date: Tue, 09 Jan 2007 01:15:15 +0100 [thread overview]
Message-ID: <enumq8$oa$1@sea.gmane.org> (raw)
In-Reply-To: Pine.LNX.4.63.0701081316110.22628@wbgn013.biozentrum.uni-wuerzburg.de
Johannes Schindelin wrote:
> On Sun, 7 Jan 2007, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>> Further, it makes no sense to force the parsing upon the helper
>>> functions; for_each_reflog_ent() now calls the helper function with
>>> old and new sha1, the email, the timestamp & timezone, and the message.
>>
>> Perhaps. I did it that way deliberately because all existing
>> users did not have to pay overhead of parsing.
>
> My reasoning is that invalid entries should rather be ignored than be
> taken into account. So, to verify that you are not walking invalid data,
> you have to parse it anyway.
I think that Junio was talking about the fact, that if you for example
do need only refname and sha1, there is no need to parse object at all.
If you don't need to, don't parse.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2007-01-09 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 0:59 [PATCH 1/2] Sanitize for_each_reflog_ent() Johannes Schindelin
2007-01-08 1:46 ` Junio C Hamano
2007-01-08 12:18 ` Johannes Schindelin
2007-01-09 0:15 ` Jakub Narebski [this message]
2007-01-09 9:57 ` Johannes Schindelin
2007-01-09 20:22 ` Junio C Hamano
2007-01-09 23:40 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='enumq8$oa$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).