From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: Syntax highlighting for gitweb
Date: Tue, 27 Feb 2007 02:45:10 +0100 [thread overview]
Message-ID: <es02au$ocf$1@sea.gmane.org> (raw)
In-Reply-To: Pine.LNX.4.63.0702261953420.22628@wbgn013.biozentrum.uni-wuerzburg.de
Johannes Schindelin wrote:
> On Mon, 26 Feb 2007, Ed Schouten wrote:
>
>> I just wrote a really awful patch to add syntax highlighting to gitweb:
>>
>> [...]
>>
>> + $pid = open2(\*HLR, \*HLW, "highlight -f --syntax c");
>
> Since this fork()s an external program, which is possibly expensive, or
> can fail because the program is not there, you should at least
>
> - document it, and
> - make it optional.
It was planned (search for "[RFC] gitweb wishlist and TODO list" in
archives), and gitweb-xmms2 (http://git.xmms.se/?p=gitweb-xmms2.git)
has it: see http://git.or.cz/gitwiki/InterfacesFrontendsAndTools#gitweb
but it was postponed together with committags support to have git config
reader in Perl to use in gitweb.
Hmmm... perhaps we should use open2 in few places where we use non-list form
of magic open "-|" (the one which spawns shell)?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
prev parent reply other threads:[~2007-02-27 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 18:18 Syntax highlighting for gitweb Ed Schouten
2007-02-26 18:55 ` Johannes Schindelin
2007-02-27 1:45 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='es02au$ocf$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).