git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* cvsserver and wincvs (cvsgui)
@ 2007-04-12 22:54 Daniel Barkalow
  2007-04-13  0:05 ` Frank Lichtenheld
  2007-04-13  0:11 ` Jakub Narebski
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Barkalow @ 2007-04-12 22:54 UTC (permalink / raw)
  To: git

I'm having problems using git-cvsserver to support a wincvs user. It seems 
to be truncating binary files in both directions (e.g., we have a PNG that 
starts, in hex, 89 50 4e 47 0d 0a ..., and it gets truncated between the 
0d and 0a), and it seems to fail up-to-date checks when checking in files 
that are, in fact, up-to-date (and, so far as I can see, haven't been 
modified anywhere else). I haven't tried much with this repository, but at 
least the binary file commit and update worked for me with real cvs.

The user is using WinCvs 1.3.13.2 Beta 13 (Build 2), which seems to be the 
version he could find at the time that would talk to both their local CVS 
server and sourceforge.

The user doesn't have any of these problems talking to a real cvs server.

Anybody got any experience with wincvs and cvsserver, or any idea how 
things could be different between git-cvsserver and real cvs? He's 
presently going to use his own version control and just send us results, 
but it would be nice if this could be magically worked out before we 
started working together closely again in a couple of weeks.

	-Daniel
*This .sig left intentionally blank*

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cvsserver and wincvs (cvsgui)
  2007-04-12 22:54 cvsserver and wincvs (cvsgui) Daniel Barkalow
@ 2007-04-13  0:05 ` Frank Lichtenheld
  2007-04-13  3:11   ` Daniel Barkalow
  2007-04-13  0:11 ` Jakub Narebski
  1 sibling, 1 reply; 4+ messages in thread
From: Frank Lichtenheld @ 2007-04-13  0:05 UTC (permalink / raw)
  To: Daniel Barkalow; +Cc: git

On Thu, Apr 12, 2007 at 06:54:22PM -0400, Daniel Barkalow wrote:
> Anybody got any experience with wincvs and cvsserver, or any idea how 
> things could be different between git-cvsserver and real cvs? He's 
> presently going to use his own version control and just send us results, 
> but it would be nice if this could be magically worked out before we 
> started working together closely again in a couple of weeks.

Looks like a problem with newline conversion. You should probably
try the gitcvs.allbinary option (available since 1.5.0 I think),
that makes git-cvsserver send all files with -kb which should suppress
the conversion.

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cvsserver and wincvs (cvsgui)
  2007-04-12 22:54 cvsserver and wincvs (cvsgui) Daniel Barkalow
  2007-04-13  0:05 ` Frank Lichtenheld
@ 2007-04-13  0:11 ` Jakub Narebski
  1 sibling, 0 replies; 4+ messages in thread
From: Jakub Narebski @ 2007-04-13  0:11 UTC (permalink / raw)
  To: git

[Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org]

Daniel Barkalow wrote:

> I'm having problems using git-cvsserver to support a wincvs user. It seems 
> to be truncating binary files in both directions (e.g., we have a PNG that 
> starts, in hex, 89 50 4e 47 0d 0a ..., and it gets truncated between the 
> 0d and 0a), and it seems to fail up-to-date checks when checking in files 
> that are, in fact, up-to-date (and, so far as I can see, haven't been 
> modified anywhere else).

Which version of git do you use?


In git-cvsserner(1) (but not in git-config(1)) we have:

  The server should set the '-k' mode to binary when relevant, however,
  this is not really implemented yet. For now, you can force the server
  to set '-kb' for all files by setting the `gitcvs.allbinary` config
  variable. In proper GIT tradition, the contents of the files are
  always respected. No keyword expansion or newline munging is supported.

Do you have gitcvs.allbinary set?


By the way, gitweb used to have the same problem. It was fixed by using
:raw mode for outputting binary files, instead of set by default :utf8
(see commit f5aa79d909f8c4838bf5).
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cvsserver and wincvs (cvsgui)
  2007-04-13  0:05 ` Frank Lichtenheld
@ 2007-04-13  3:11   ` Daniel Barkalow
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Barkalow @ 2007-04-13  3:11 UTC (permalink / raw)
  To: Frank Lichtenheld; +Cc: git

On Fri, 13 Apr 2007, Frank Lichtenheld wrote:

> On Thu, Apr 12, 2007 at 06:54:22PM -0400, Daniel Barkalow wrote:
> > Anybody got any experience with wincvs and cvsserver, or any idea how 
> > things could be different between git-cvsserver and real cvs? He's 
> > presently going to use his own version control and just send us results, 
> > but it would be nice if this could be magically worked out before we 
> > started working together closely again in a couple of weeks.
> 
> Looks like a problem with newline conversion. You should probably
> try the gitcvs.allbinary option (available since 1.5.0 I think),
> that makes git-cvsserver send all files with -kb which should suppress
> the conversion.

That seems plausible; I think I'd read the documentation too while too 
sick and thought the fact that cvsserver, like git in general, doesn't 
change anything meant that it would also tell clients that nothing should 
be changed. Thanks; I've got a suitable version, and I'll try it and see 
if the user still has problems.

	-Daniel
*This .sig left intentionally blank*

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-04-13  3:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-12 22:54 cvsserver and wincvs (cvsgui) Daniel Barkalow
2007-04-13  0:05 ` Frank Lichtenheld
2007-04-13  3:11   ` Daniel Barkalow
2007-04-13  0:11 ` Jakub Narebski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).