From: Torsten Krah <krah.tm@gmail.com>
To: git@vger.kernel.org
Subject: Re: Broken branch after git commit - tracked files in staging area can't be removed with restore --staged, or commit or stash
Date: Tue, 07 Jan 2020 16:28:24 +0100 [thread overview]
Message-ID: <f0638fc0d09c213b661d2b244d3457f362daebe0.camel@gmail.com> (raw)
In-Reply-To: <234df85965f8a685be5e563fe795ed477f359d7c.camel@gmail.com>
Am Dienstag, den 07.01.2020, 14:43 +0100 schrieb Torsten Krah:
> Although restore --staged moved my unwanted files away from the
> staging
> area and "git status" told me that they are not "in" the commit the
> commit itself did still include them.
I can reproduce that (locally) at least:
What does *not* work for me:
git clone XX main
cd main
git fetch XX && git checkout FETCH_HEAD
git checkout -b TEST
git reset --soft HEAD~1
git restore --staged $FILES
git status now lists $FILES as unstaged and they are not included in
the staging area.
git commit
-> now $FILES are included in the commit (I would expect them not to be
included - right?) and git status does list those still in the working
area.
What does work:
git clone XX main
cd main
git fetch XX && git checkout FETCH_HEAD
git checkout -b TEST
git reset --soft HEAD~1
git reset HEAD $FILES
git status now lists $FILES as unstaged and they are not included in
the staging area.
git commit
produces a commit where $FILES are not included and they are still in
the working area, unstaged - like expected.
git status tells me this in the staging area part:
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
I did that and its not working (for me) - looks at least like a bug or
I am doing something wrong and I am just too dumb at the moment to see
my failure.
Cheers
Torsten
PS: $FILES are files which are all "new" and first time added in the
commit I want to modify with restore.
PPS: The second problem with those staged deleted, unstageable,
uncomittable files still persists in my copy of those branch (I can't
reproduce that - still I have the repository in that state).
next prev parent reply other threads:[~2020-01-07 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 12:55 Broken branch after git commit - tracked files in staging area can't be removed with restore --staged, or commit or stash Torsten Krah
2020-01-07 13:43 ` Torsten Krah
2020-01-07 15:28 ` Torsten Krah [this message]
2020-01-08 9:11 ` Jeff King
2020-01-08 10:02 ` Torsten Krah
2020-01-08 10:31 ` Torsten Krah
2020-01-08 10:40 ` Jeff King
2020-01-08 11:43 ` [PATCH] restore: invalidate cache-tree when removing entries with --staged Jeff King
2020-01-08 15:41 ` Junio C Hamano
2020-02-05 20:24 ` Dennis Kaarsemaker
2020-01-08 12:42 ` Broken branch after git commit - tracked files in staging area can't be removed with restore --staged, or commit or stash Torsten Krah
2020-01-09 9:39 ` Jeff King
2020-01-09 10:49 ` Torsten Krah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0638fc0d09c213b661d2b244d3457f362daebe0.camel@gmail.com \
--to=krah.tm@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).