git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Oakley <philipoakley@iee.org>
To: Git List <git@vger.kernel.org>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Thomas Braun" <thomas.braun@virtuell-zuhause.de>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: test suite: why does git add large_file create a pack, rather than an object?
Date: Sat, 30 Mar 2019 14:13:15 +0000	[thread overview]
Message-ID: <f0c838f0-2f75-2b05-1aeb-3db4743ce89a@iee.org> (raw)

I'm looking at the Git-for-Windows(GfW) >4Gb  large file problem 
following Torsten and Thomas's work (and others). [1,2,3, etc.]

I've added a few more changes to my branch [2] to get the zlib to 
properly count past its 32bit limit when wrapped in the git_inflate 
(etc) wrapper code. [4]

At the moment I'm using an extended _test_ case that starts by adding a 
~5.1Gb file and then using verify-pack, which aborts with an error.

         dd if=/dev/zero of=file bs=1M count=5100 &&
         git config core.compression 0 &&
         git config core.looseCompression 0 &&
         git add file &&
         git verify-pack -s .git/objects/pack/*.pack &&
         git fsck --verbose --strict --full &&
         ...

If however I simple execute the commands from the GfW bash, the added 
file is stored as a blob object, rather than a pack.

I'm at a loss to understand the reason for the change in behaviour 
[store file as pack, vs store as object] between running the code as a 
test script and at the terminal. What am I missing?

I have 'good' output from the test script on the WSL (and have 
identified the packs' specific byte differences), but my gdb experience 
is limited so executing that test while within the test script meant I 
couldn't start debugging there. Hence the direct execution from the 
terminal that raised the issue.

-- 

Philip
[1] <20190131203842.633ztr4yckn7kl2d@tb-raspi4>
[2] https://github.com/gitgitgadget/git/pull/115#issuecomment-4753008375
[3] https://github.com/git-for-windows/git/issues/1848
[4] https://github.com/PhilipOakley/git/tree/size_t2


             reply	other threads:[~2019-03-30 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 14:13 Philip Oakley [this message]
2019-04-01 10:47 ` test suite: why does git add large_file create a pack, rather than an object? Junio C Hamano
2019-04-01 15:09   ` Philip Oakley
2019-04-02 10:35     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0c838f0-2f75-2b05-1aeb-3db4743ce89a@iee.org \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=tboegi@web.de \
    --cc=thomas.braun@virtuell-zuhause.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).