From: Phillip Wood <phillip.wood123@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2025, #06; Tue, 22)
Date: Wed, 23 Jul 2025 10:40:23 +0100 [thread overview]
Message-ID: <f1d3c903-b7c6-46b2-b911-0ec8c2708c8c@gmail.com> (raw)
In-Reply-To: <aIB0lUS8OTq-oPw7@pks.im>
On 23/07/2025 06:35, Patrick Steinhardt wrote:
> On Tue, Jul 22, 2025 at 05:11:35PM -0700, Junio C Hamano wrote:
>> * ps/config-wo-the-repository (2025-07-17) 22 commits
>> - config: fix sign comparison warnings
>> - config: move Git config parsing into "environment.c"
>> - config: remove unused `the_repository` wrappers
>> - config: drop `git_config_set_multivar()` wrapper
>> - config: drop `git_config_get_multivar_gently()` wrapper
>> - config: drop `git_config_set_multivar_in_file_gently()` wrapper
>> - config: drop `git_config_set_in_file_gently()` wrapper
>> - config: drop `git_config_set()` wrapper
>> - config: drop `git_config_set_gently()` wrapper
>> - config: drop `git_config_set_in_file()` wrapper
>> - config: drop `git_config_get_bool()` wrapper
>> - config: drop `git_config_get_ulong()` wrapper
>> - config: drop `git_config_get_int()` wrapper
>> - config: drop `git_config_get_string()` wrapper
>> - config: drop `git_config_get_string()` wrapper
>> - config: drop `git_config_get_string_multi()` wrapper
>> - config: drop `git_config_get_value()` wrapper
>> - config: drop `git_config_get_value()` wrapper
>> - config: drop `git_config_get()` wrapper
>> - config: drop `git_config_clear()` wrapper
>> - config: drop `git_config()` wrapper
>> - Merge branch 'bc/use-sha256-by-default-in-3.0' into ps/config-wo-the-repository
>>
>> The config API had a set of convenience wrapper functions that
>> implicitly use the_repository instance; they have been removed and
>> inlined at the calling sites.
>>
>> Will merge to 'next'?
>> source: <20250717-pks-config-wo-the-repository-v1-0-d888e4a17de1@pks.im>
>
> I think the only commit that really needs review is the last one that
> fixes the sign comparison warnings. As long as people are fine with that
> commit I'm happy to have it merged.
I think that commit needs a re-roll c.f.
<2b914b60-3417-4a49-b545-3109c9a05257@gmail.com>. I haven't looked at
the rest of the patches but I like the general idea behind this series.
Thanks
Phillip
> Patrick
>
next prev parent reply other threads:[~2025-07-23 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 0:11 What's cooking in git.git (Jul 2025, #06; Tue, 22) Junio C Hamano
2025-07-23 5:35 ` Patrick Steinhardt
2025-07-23 9:40 ` Phillip Wood [this message]
2025-07-23 17:17 ` Junio C Hamano
2025-07-23 15:48 ` Junio C Hamano
2025-07-23 7:40 ` Eric Sunshine
2025-07-23 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d3c903-b7c6-46b2-b911-0ec8c2708c8c@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).