From: Thomas Rast <trast@inf.ethz.ch>
To: <git@vger.kernel.org>
Cc: Jens Lehmann <Jens.Lehmann@web.de>
Subject: [PATCH 3/4] coverage: set DEFAULT_TEST_TARGET to avoid using prove
Date: Mon, 13 May 2013 23:27:27 +0200 [thread overview]
Message-ID: <f27a438797cf249ccc3621a580653ea1827033f6.1368479988.git.trast@inf.ethz.ch> (raw)
In-Reply-To: <cover.1368479988.git.trast@inf.ethz.ch>
If the user sets DEFAULT_TEST_TARGET=prove in his config.mak, that
carries over into the coverage tests. Which is really bad if he also
sets GIT_PROVE_OPTS=-j<..> as that completely breaks the coverage
runs.
Instead of attempting to mess with the GIT_PROVE_OPTS, just force the
test target to 'test' so that we run under make, like we intended all
along.
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 99e4d09..153d24d 100644
--- a/Makefile
+++ b/Makefile
@@ -2551,7 +2551,7 @@ coverage-compile:
coverage-test: coverage-clean-results coverage-compile
$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
- -j1 test
+ DEFAULT_TEST_TARGET=test -j1 test
coverage-report:
$(QUIET_GCOV)for dir in $(object_dirs); do \
--
1.8.3.rc1.400.g07d6e4a
next prev parent reply other threads:[~2013-05-13 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 21:27 [PATCH 0/4] Coverage support revisited Thomas Rast
2013-05-13 21:27 ` [PATCH 1/4] coverage: split build target into compile and test Thomas Rast
2013-05-13 21:27 ` [PATCH 2/4] coverage: do not delete .gcno files before building Thomas Rast
2013-05-13 21:27 ` Thomas Rast [this message]
2013-05-13 21:27 ` [PATCH 4/4] coverage: build coverage-untested-functions by default Thomas Rast
2013-05-13 22:14 ` [PATCH 0/4] Coverage support revisited Junio C Hamano
2013-05-13 22:33 ` Jens Lehmann
2013-05-14 9:14 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27a438797cf249ccc3621a580653ea1827033f6.1368479988.git.trast@inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).