From: "Tomi Pakarinen" <tomi.pakarinen@gmail.com>
To: "Robin Rosenberg" <robin.rosenberg.lists@dewire.com>
Cc: spearce@spearce.org, git@vger.kernel.org
Subject: Re: [EGIT PATCH] git property page for project properties.
Date: Tue, 21 Oct 2008 21:09:13 +0300 [thread overview]
Message-ID: <f299b4f30810211109q7f2919f2r1d5cd8faf0048154@mail.gmail.com> (raw)
In-Reply-To: <200810211950.50540.robin.rosenberg.lists@dewire.com>
On Tue, Oct 21, 2008 at 8:50 PM, Robin Rosenberg
<robin.rosenberg.lists@dewire.com> wrote:
> måndagen den 20 oktober 2008 21.06.44 skrev Tomi Pakarinen:
>> Show git property page in project's properties, if project
>> has git repository provider.
> [...]
>> + switch (repository.getRepositoryState()) {
>> + case BISECTING:
>> + state.setText("Bisecting");
>> + break;
>> + case MERGING:
>> + state.setText("Merging");
>> + break;
>> + case REBASING:
>> + state.setText("Rebasing");
>> + break;
>> + case REBASING_INTERACTIVE:
>> + state.setText("Rebasing interactive");
>> + break;
>> + case REBASING_MERGE:
>> + state.setText("Rebasing merge");
>> + break;
>> + case SAFE:
>> + state.setText("Safe");
>> + break;
>> + }
> Why not this:
>
> state.setText(repository.getRepositoryState().getDescription());
>
> Description is ment for presentation purposes. The enum for code.
>
> -- robin
>
That is ok. I just didn't notice that method before. But, what if
someone wants localize this plugin, he'll propably have to explode
this back to switch statement.
Tomi.
next prev parent reply other threads:[~2008-10-21 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 19:06 [EGIT PATCH] git property page for project properties Tomi Pakarinen
2008-10-21 5:37 ` Robin Rosenberg
2008-10-21 17:50 ` Robin Rosenberg
2008-10-21 18:09 ` Tomi Pakarinen [this message]
2008-10-21 19:13 ` Robin Rosenberg
2008-10-21 20:13 ` [JGIT PATCH] Detect repository states according to post Git 1.5 Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f299b4f30810211109q7f2919f2r1d5cd8faf0048154@mail.gmail.com \
--to=tomi.pakarinen@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=spearce@spearce.org \
--cc=tomi.pakarinen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).