From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from bsmtp.bon.at (bsmtp.bon.at [213.33.87.14])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4767327AC30
	for <git@vger.kernel.org>; Thu,  5 Jun 2025 21:11:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.33.87.14
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1749157901; cv=none; b=Lm6EuM5ra4/54VnHQjcDjC34qYo4r0+kjNcYFm6BO9Iyg4yw6yA72PQKF2G0BYfYVeXBh6JwKUgcHAGi/3GeqnZfPNoIjwo6/+80QLahtawW9LiQhUx99ord9EmmfZII138klu112CmDhYrHSDJXFoUMZxa9old4aaDDfq6EGvA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1749157901; c=relaxed/simple;
	bh=2AGwCTHlh2ekbxnTcl3yUKIIvhSzHJvocerlaIloAyQ=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=Btz+vnUcdc71TILZFsiSuZGtyBtV/yXyP0bLQCnFuZuhlMpAOr07+v5u5wzweyuWGae7wOVsqA5rdJaT/r28nFeWuDnVGAaP7P8SJg630mHkLJMltJubWmuPsJn7IYKN37cfymyuwh1ZBnclhDBRnyJh1qB86TBOmI0cZZF0pQQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kdbg.org; spf=pass smtp.mailfrom=kdbg.org; arc=none smtp.client-ip=213.33.87.14
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kdbg.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kdbg.org
Received: from [192.168.0.100] (unknown [93.83.142.38])
	by bsmtp.bon.at (Postfix) with ESMTPSA id 4bCxvq5TbtzRnmS;
	Thu,  5 Jun 2025 23:11:35 +0200 (CEST)
Message-ID: <f2ed8920-347d-45d3-a0bb-df94ece0d9df@kdbg.org>
Date: Thu, 5 Jun 2025 23:11:35 +0200
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
List-Id: <git.vger.kernel.org>
List-Subscribe: <mailto:git+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:git+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed
Content-Language: en-US
To: rsbecker@nexbridge.com, 'Patrick Steinhardt' <ps@pks.im>
Cc: 'Junio C Hamano' <gitster@pobox.com>, git@vger.kernel.org,
 'Todd Zullinger' <tmz@pobox.com>
References: <xmqqsekgn4gk.fsf@gitster.g>
 <007a01dbd4d7$89ebf100$9dc3d300$@nexbridge.com>
 <007d01dbd4d9$356ded70$a049c850$@nexbridge.com>
 <aEBPdFXpIca7lMls@teonanacatl.net> <xmqqjz5rcz90.fsf@gitster.g>
 <44fe8627-5680-443d-bf02-a6e85afd46b4@kdbg.org>
 <010b01dbd5f1$3c26ec20$b474c460$@nexbridge.com> <aEFb0Sjj0Xuu-t7l@pks.im>
 <014201dbd658$4da75680$e8f60380$@nexbridge.com>
From: Johannes Sixt <j6t@kdbg.org>
In-Reply-To: <014201dbd658$4da75680$e8f60380$@nexbridge.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Am 05.06.25 um 22:27 schrieb rsbecker@nexbridge.com:
> The *.tcl files in git-gui/lib are gone after the above command. I noticed a
> few things run by the above - this did not happen in 2.49.
> 
> /usr/coreutils/bin/make -C git-gui
> gitexecdir='/usr/local-ssl3.5/libexec/git-core' all
> make[1]: Entering directory
> '/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/git-gui'
> GITGUI_VERSION=0.21.GITGUI
> /usr/coreutils/bin/bash generate-git-gui.sh "git-gui.sh" "git-gui"
> ./GIT-GUI-BUILD-OPTIONS ./GIT-VERSION-FILE
> /usr/coreutils/bin/bash generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS
> lib/merge.tcl lib/error.tcl lib/chord.tcl lib/date.tcl lib/encoding.tcl
...
> generate-tclindex.sh: line 21: tclsh: command not found
>     * tclsh failed; using unoptimized loading
> 
> It appears the above removes the *.tcl files. That causes the subsequent
> failure.

Interesting. We have this in generate-tclindex.sh:

...
else
         echo >&2 "    * $TCL_PATH failed; using unoptimized loading"
         rm -f $@
         echo '# Autogenerated by git-gui Makefile' >lib/tclIndex
...

This $@ was taken literally from the Makefile, where it means something
very different than in the shell script. The line could be

         rm -f lib/tclIndex

or it could be deleted because the next line overwrites the file anyway.

In the meantime, setting NO_TCLTK=NoThanks in config.mak is probably the
quickest fix for you.

Thank you for the report.
-- Hannes