git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Document git-blame triple -C option
Date: Sat, 9 Jan 2010 00:28:52 +0530	[thread overview]
Message-ID: <f3271551001081058l4fffa51t7ec52e9ce2f3166e@mail.gmail.com> (raw)
In-Reply-To: <4B47510E.7040802@drmicha.warpmail.net>

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

> Above you see why it is difficult to comment on attached patches.
> They're not included!

I'm sorry, but I'm behind a HTTP proxy, and GMail mangles up patches.
I'm left with no choice but to attach the patches.

> You re-wrapped the existing documentation. Please don't do that, because
> it makes it difficult to spot what you really changed.

Okay. Corrected.

> It seems you added one sentence. Please don't use "thrice" for "three
> times", that is very old English and sounds funny.

Okay. I've also modified the second line (what happens when the option
is given twice) for clarity.

[-- Attachment #2: 0001-Document-git-blame-triple-C-option.patch --]
[-- Type: text/x-patch, Size: 1892 bytes --]

From 371705f64576ff7b8dc82bea19c714ce320097b9 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sat, 9 Jan 2010 00:18:07 +0530
Subject: [PATCH v2] Document git-blame triple -C option

git-blame -CCC is explained in builin-blame.c line 2171, but is
unexplained in the documentation. This patch fixes that.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Documentation/blame-options.txt |    6 ++++--
 Documentation/git-blame.txt     |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/blame-options.txt b/Documentation/blame-options.txt
index 1625ffc..4833cac 100644
--- a/Documentation/blame-options.txt
+++ b/Documentation/blame-options.txt
@@ -98,8 +98,10 @@ commit.
 	files that were modified in the same commit.  This is
 	useful when you reorganize your program and move code
 	around across files.  When this option is given twice,
-	the command additionally looks for copies from all other
-	files in the parent for the commit that creates the file.
+	the command additionally looks for copies from other
+	files in the commit that creates the file. When this
+	option is given three times, the command additionally
+	looks for copies from other files in any commit.
 +
 <num> is optional but it is the lower bound on the number of
 alphanumeric characters that git must detect as moving
diff --git a/Documentation/git-blame.txt b/Documentation/git-blame.txt
index 8c7b7b0..b786471 100644
--- a/Documentation/git-blame.txt
+++ b/Documentation/git-blame.txt
@@ -9,7 +9,7 @@ SYNOPSIS
 --------
 [verse]
 'git blame' [-c] [-b] [-l] [--root] [-t] [-f] [-n] [-s] [-p] [-w] [--incremental] [-L n,m]
-            [-S <revs-file>] [-M] [-C] [-C] [--since=<date>]
+	    [-S <revs-file>] [-M] [-C] [-C] [-C] [--since=<date>]
 	    [<rev> | --contents <file> | --reverse <rev>] [--] <file>
 
 DESCRIPTION
-- 
1.6.5


      reply	other threads:[~2010-01-08 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08 14:10 [PATCH] Document git-blame triple -C option Ramkumar Ramachandra
2010-01-08 15:36 ` Michael J Gruber
2010-01-08 18:58   ` Ramkumar Ramachandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3271551001081058l4fffa51t7ec52e9ce2f3166e@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).