From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Gabriel Filion <lelutin@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Michael J Gruber <git@drmicha.warpmail.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Subject: Re: [PATCH v7 1/2] Documentation/remote-helpers: Rewrite description
Date: Mon, 29 Mar 2010 11:48:18 +0530 [thread overview]
Message-ID: <f3271551003282318vc256d20j90bb83170b0a983@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1003290055000.14365@iabervon.org>
Hi,
> That information ought to be in the documentation, but possibly not on
> this man page in particular. I think it would be better to document that
> part in the documentation of the code and programs that call the helper,
> not in the helper documentation.
I agree that the callers need to document the subset of the
invocations they make to remote helpers. I think we can defer this
until we have a real remote helper in `git.git` that actually
interfaces with a foreign versioning system.
I've thought about documenting the full set of invocations in the code
for the developer, but there's a problem. Here's an excerpt from
remote-curl.c, showing how it parses its command line arguments:
remote = remote_get(argv[1]);
if (argc > 2) {
url = argv[2];
} else {
url = remote->url[0];
}
Unfortunately, I don't see where else this documentation can fit in:
if it were to go into a specific remote helper's code, then it'll have
to be duplicated for all the remote helpers, since all of them parse
options similarly. It certainly cannot go into remote.c or
transport-helper.c, because they have little/ nothing to do with the
actual argument parsing.
I could try modifying the documentation I've written to serve more to
specify "how remote helpers are invoked" and less about "how callers
invoke remote helpers", and try to fit it in this manpage. It's more
of a developer manpage and less of an end-user manpage as it is. Or we
could create another page about remote helpers intended to be read
exclusively by developers. What are your thoughts on this?
-- Ram
next prev parent reply other threads:[~2010-03-29 6:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 18:03 [PATCH v7 1/2] Documentation/remote-helpers: Rewrite description Ramkumar Ramachandra
2010-03-29 1:17 ` Gabriel Filion
2010-03-29 3:04 ` Ramkumar Ramachandra
2010-03-29 3:08 ` Sverre Rabbelier
2010-03-29 5:09 ` Daniel Barkalow
2010-03-29 6:18 ` Ramkumar Ramachandra [this message]
2010-03-29 6:39 ` Jonathan Nieder
2010-03-29 15:39 ` Daniel Barkalow
2010-03-30 3:23 ` Ramkumar Ramachandra
2010-03-29 3:25 ` Tay Ray Chuan
2010-03-29 3:45 ` Ramkumar Ramachandra
2010-04-05 14:05 ` Ramkumar Ramachandra
2010-04-05 21:55 ` Junio C Hamano
2010-04-06 2:47 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3271551003282318vc256d20j90bb83170b0a983@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=jrnieder@gmail.com \
--cc=lelutin@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).