* [PATCH] Mention libiconv as a requirement for git-am
@ 2007-07-31 15:09 Nguyen Thai Ngoc Duy
2007-08-01 3:03 ` Han-Wen Nienhuys
0 siblings, 1 reply; 4+ messages in thread
From: Nguyen Thai Ngoc Duy @ 2007-07-31 15:09 UTC (permalink / raw)
To: git, Johannes Sixt, Han-Wen Nienhuys
---
Han-Wen, any chance to include libiconv to the installer? You may need
to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.
README.MinGW | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/README.MinGW b/README.MinGW
index 89b7065..c0b8f66 100644
--- a/README.MinGW
+++ b/README.MinGW
@@ -28,6 +28,7 @@ In order to compile this code you need:
zlib-1.2.3-mingwPORT-1.tar
w32api-3.6.tar.gz
tcltk-8.4.1-1.exe (for gitk, git-gui)
+ libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)
STATUS
--
1.5.0.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Mention libiconv as a requirement for git-am
2007-07-31 15:09 [PATCH] Mention libiconv as a requirement for git-am Nguyen Thai Ngoc Duy
@ 2007-08-01 3:03 ` Han-Wen Nienhuys
2007-08-01 3:18 ` Nguyen Thai Ngoc Duy
0 siblings, 1 reply; 4+ messages in thread
From: Han-Wen Nienhuys @ 2007-08-01 3:03 UTC (permalink / raw)
To: Nguyen Thai Ngoc Duy; +Cc: git, Johannes Sixt
libiconv is already in there, version 1.11,
[lilydev@haring gub]$ grep bin.libiconv
target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt
\usr\bin\libiconv-2.dll
I don't understand your request: do you want to have some flags added
to the environment?
2007/7/31, Nguyen Thai Ngoc Duy <pclouds@gmail.com>:
> ---
> Han-Wen, any chance to include libiconv to the installer? You may need
> to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.
>
> README.MinGW | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/README.MinGW b/README.MinGW
> index 89b7065..c0b8f66 100644
> --- a/README.MinGW
> +++ b/README.MinGW
> @@ -28,6 +28,7 @@ In order to compile this code you need:
> zlib-1.2.3-mingwPORT-1.tar
> w32api-3.6.tar.gz
> tcltk-8.4.1-1.exe (for gitk, git-gui)
> + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)
>
>
> STATUS
> --
> 1.5.0.7
>
--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Mention libiconv as a requirement for git-am
2007-08-01 3:03 ` Han-Wen Nienhuys
@ 2007-08-01 3:18 ` Nguyen Thai Ngoc Duy
2007-08-01 3:36 ` Han-Wen Nienhuys
0 siblings, 1 reply; 4+ messages in thread
From: Nguyen Thai Ngoc Duy @ 2007-08-01 3:18 UTC (permalink / raw)
To: hanwen; +Cc: git, Johannes Sixt
I'm sorry I judged by reading Makefile without actually testing your
installation, so I might be wrong. By default Makefile set
NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it
exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in
config.mak in order to enable it.
I'm going to test it tomorrow.
On 7/31/07, Han-Wen Nienhuys <hanwenn@gmail.com> wrote:
> libiconv is already in there, version 1.11,
>
> [lilydev@haring gub]$ grep bin.libiconv
> target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt
> \usr\bin\libiconv-2.dll
>
> I don't understand your request: do you want to have some flags added
> to the environment?
>
> 2007/7/31, Nguyen Thai Ngoc Duy <pclouds@gmail.com>:
> > ---
> > Han-Wen, any chance to include libiconv to the installer? You may need
> > to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.
> >
> > README.MinGW | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/README.MinGW b/README.MinGW
> > index 89b7065..c0b8f66 100644
> > --- a/README.MinGW
> > +++ b/README.MinGW
> > @@ -28,6 +28,7 @@ In order to compile this code you need:
> > zlib-1.2.3-mingwPORT-1.tar
> > w32api-3.6.tar.gz
> > tcltk-8.4.1-1.exe (for gitk, git-gui)
> > + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)
> >
> >
> > STATUS
> > --
> > 1.5.0.7
> >
>
>
> --
> Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
>
--
Duy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Mention libiconv as a requirement for git-am
2007-08-01 3:18 ` Nguyen Thai Ngoc Duy
@ 2007-08-01 3:36 ` Han-Wen Nienhuys
0 siblings, 0 replies; 4+ messages in thread
From: Han-Wen Nienhuys @ 2007-08-01 3:36 UTC (permalink / raw)
To: Nguyen Thai Ngoc Duy; +Cc: git, Johannes Sixt
2007/8/1, Nguyen Thai Ngoc Duy <pclouds@gmail.com>:
> I'm sorry I judged by reading Makefile without actually testing your
> installation, so I might be wrong. By default Makefile set
> NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it
> exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in
> config.mak in order to enable it.
this is done automatically when running configure. If you find a
problem with the installer please let me know.
> I'm going to test it tomorrow.
--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-01 3:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-31 15:09 [PATCH] Mention libiconv as a requirement for git-am Nguyen Thai Ngoc Duy
2007-08-01 3:03 ` Han-Wen Nienhuys
2007-08-01 3:18 ` Nguyen Thai Ngoc Duy
2007-08-01 3:36 ` Han-Wen Nienhuys
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).