From: "Yakov Lerner" <iler.ml@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] auto-detect changed $prefix in Makefile and properly rebuild to avoid broken install
Date: Thu, 15 Jun 2006 11:11:55 +0000 [thread overview]
Message-ID: <f36b08ee0606150411q67fce728vad6dc0403160f95a@mail.gmail.com> (raw)
In-Reply-To: <E1Fqo70-0003pZ-PU@moooo.ath.cx>
On 6/15/06, Matthias Lederhofer <matled@gmx.net> wrote:
> > Either GIT-CFLAGS or GIT-BUILD-FLAGS,
> > whichever is shorter :-)
>
> I would not take GIT-CFLAGS because there is an environment variable
> used by make named CFLAGS and means something else.
What is your preference for this filename ? Is GIT-BUILD-FLAGS
better ? GIT-FLAGS ? Other ?
GIT-CFLAGS is filename here, whereas $(CFLAGS) is variable.
Maybe writing it the filename ./GIT-CFLAGS would
emphasize betterthat it's not make variable, but a filename ?
> What is the target test-prefix-change good for? Should it really be
> included?
The purpose of 'test-prefix-change' is to check that there are no
missing GIT-FLAGS as prerequisite which would result in broken install
if prefix changed between 'make' and 'make install'. The
'make test-prefix-change' would catch it if GIT-FLAGS happened
to be missing in some places that if substantially dependent of $prefix.
Yakov
next prev parent reply other threads:[~2006-06-15 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 19:26 [PATCH] auto-detect changed $prefix in Makefile and properly rebuild to avoid broken install Yakov Lerner
2006-06-14 20:04 ` Junio C Hamano
2006-06-14 20:30 ` Yakov Lerner
2006-06-14 21:32 ` Junio C Hamano
2006-06-14 21:38 ` Yakov Lerner
2006-06-15 9:26 ` Matthias Lederhofer
2006-06-15 11:11 ` Yakov Lerner [this message]
2006-06-18 13:31 ` Petr Baudis
2006-06-15 11:26 ` Santi
2006-06-15 11:40 ` Yakov Lerner
2006-06-15 12:49 ` Santi
2006-06-15 13:00 ` Alexander Litvinov
2006-06-17 5:28 ` Junio C Hamano
2006-06-17 5:26 ` Junio C Hamano
2006-06-18 11:24 ` Karl Hasselström
2006-06-18 11:47 ` Junio C Hamano
2006-06-18 14:44 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f36b08ee0606150411q67fce728vad6dc0403160f95a@mail.gmail.com \
--to=iler.ml@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).