From: Yakov Lerner <iler.ml@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] fix obscure perl message when encryption=tls and smtp cannot connect.
Date: Sat, 26 Sep 2009 00:39:52 +0300 [thread overview]
Message-ID: <f36b08ee0909251439o38b8e414nc7621085d7489ade@mail.gmail.com> (raw)
In-Reply-To: <20090925213440.GX14660@spearce.org>
On Sat, Sep 26, 2009 at 00:34, Shawn O. Pearce <spearce@spearce.org> wrote:
>
> iler.ml@gmail.com wrote:
> > When encryption=tls and smtp cannot connect, git-send-email prints following perl error:
> >
> > Can't call method "command" on an undefined value at /usr/local/libexec/git-core/git-send-email line 927.
> >
> > (ithis is when smtp host orport is misspelled, or network is down, and encryption is tls).
> > We expect some familiar "Cannot connect to SERVER:PORT" message.
> > Fix it to print normal "smtp can't connect" diagnostics.
>
> Thanks, looks reasonable. Signed-off-by line, per the Developer's
> Certificate of Origin in Documentation/SubmittingPatches ?
Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
>
> > --- /usr/local/libexec/git-core/git-send-email.000 2009-09-26 00:10:01.000000000 +0300
> > +++ /usr/local/libexec/git-core/git-send-email 2009-09-26 00:11:39.000000000 +0300
> > @@ -922,7 +922,7 @@
> > $smtp ||= Net::SMTP->new((defined $smtp_server_port)
> > ? "$smtp_server:$smtp_server_port"
> > : $smtp_server);
> > - if ($smtp_encryption eq 'tls') {
> > + if ($smtp_encryption eq 'tls' && $smtp) {
> > require Net::SMTP::SSL;
> > $smtp->command('STARTTLS');
> > $smtp->response();
>
Yakov
prev parent reply other threads:[~2009-09-25 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 21:30 [PATCH] fix obscure perl message when encryption=tls and smtp cannot connect iler.ml
2009-09-25 21:34 ` Shawn O. Pearce
2009-09-25 21:39 ` Yakov Lerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f36b08ee0909251439o38b8e414nc7621085d7489ade@mail.gmail.com \
--to=iler.ml@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).