From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
Date: Fri, 21 Sep 2018 13:40:40 -0400 [thread overview]
Message-ID: <f3fcdef1-e051-0132-5cde-839188374ad7@gmail.com> (raw)
In-Reply-To: <xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com>
On 9/21/2018 1:05 PM, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>> (hdr-check)) didn't make it onto 'pu' - was there something else I
>> needed to do? (I am still in two minds about sending an RFC patch
>> on-top of patch #9).
> I refrained from queuing it as I did not sense a clear resolution of
> the discussion.
>
> I found it a sign that you may want to update the log message to
> explain "instead of adding a few forward decls, include the whole
> commit.h because..." that you had to explain why the patch did what
> it did to Derrick in a follow-up message.
Also my fault for not saying "That's a good reason, thanks for
explaining!" (I'll add that to the necessary thread.)
-Stolee
prev parent reply other threads:[~2018-09-21 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 0:18 [PATCH] fetch-object.h: add missing declaration (hdr-check) Ramsay Jones
2018-09-21 16:21 ` Junio C Hamano
2018-09-21 16:47 ` Ramsay Jones
2018-09-21 17:05 ` Junio C Hamano
2018-09-21 17:40 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3fcdef1-e051-0132-5cde-839188374ad7@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).