From: Kirill <kirillathome@gmail.com>
To: Jeff Epler <jepler@unpythonic.net>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH] Provide a window icon on Windows platforms
Date: Thu, 31 Dec 2009 15:13:43 -0500 [thread overview]
Message-ID: <f579dd580912311213u2515334fxb811354f59fe05a5@mail.gmail.com> (raw)
In-Reply-To: <20091231200240.GC13700@unpythonic.net>
On Thu, Dec 31, 2009 at 3:02 PM, Jeff Epler wrote:
> On Thu, Dec 31, 2009 at 02:57:50PM -0500, Kirill wrote:
>> + set ::tk::AlwaysShowSelection 1
>> +
>> + # Spoof an X11 display for SSH
>> + if {![info exists env(DISPLAY)]} {
>> + set env(DISPLAY) :9999
>> + }
>
> these bits look unrelated and should probably be in a separate
> submission.
The only reason this code is here: Git Gui has it in the same section.
Given my total lack of Tcl/Tk skills and deep understanding, I hoped
to fix some other Windows-specific annoyances "by accident".
If Tcl/Tk gurus, for example, Paul Mackerras, say they're wrong, I'll
gladly remove them. If the only objection is the inclusion into the
same patch, I can do that too.
Thanks for your time!
--
Kirill.
next prev parent reply other threads:[~2009-12-31 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 19:57 [PATCH] Provide a window icon on Windows platforms Kirill
2009-12-31 20:02 ` Jeff Epler
2009-12-31 20:13 ` Kirill [this message]
2009-12-31 21:12 ` [msysGit] " Pat Thoyts
2009-12-31 22:42 ` Kirill
2009-12-31 23:47 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f579dd580912311213u2515334fxb811354f59fe05a5@mail.gmail.com \
--to=kirillathome@gmail.com \
--cc=git@vger.kernel.org \
--cc=jepler@unpythonic.net \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).