From: Kirill <kirillathome@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Pat Thoyts <patthoyts@googlemail.com>,
Paul Mackerras <paulus@samba.org>,
msysgit@googlegroups.com, git@vger.kernel.org
Subject: Re: [GITK PATCH 3/3] gitk: strip prefix from filenames in subdirectories
Date: Tue, 23 Feb 2010 14:42:29 -0500 [thread overview]
Message-ID: <f579dd581002231142v6a937ac0xdc9618f2a468989d@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1002231811021.3980@intel-tinevez-2-302>
Hi,
On Tue, Feb 23, 2010 at 12:12 PM, Johannes Schindelin wrote:
>
> Again in the lower right panel, where the file names of the files touched
> by the current commit are clickable: let's not show the prefix when we
> are in a subdirectory, as it wastes precious screen estate conveying
> information the user already knows.
Unfortunately, it seems to be too aggressive, leading to a misleading
display. When gitk is invoked from a subdirectory but without the
filter, the lower right panel displays some paths, relative to the
root of the work tree, and some, relative to the wd:
$ # fresh netinstall with checked out devel's
$ cd /
$ gitk --all & # 1
$ cd /bin
$ gitk --all & # 2
1. bin/move-wiki.sh when devel is selected; share/WinGit/install.iss -
when installer-improvements is selected (that's correct)
2. move-wiki.sh on devel; share/WinGit/install.iss on installer-improvements
That's misleading.
And honestly, I'm not that advanced in gitk use, so somebody will
probably have to do some more testing.
Thanks!
--
Kirill.
next prev parent reply other threads:[~2010-02-23 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f579dd581002200847o340a3eb9l50d0f1329d4e2c23@mail.gmail.com>
[not found] ` <alpine.DEB.1.00.1002201847290.20986@pacific.mpi-cbg.de>
[not found] ` <a5b261831002200948v3c01708dv3e42d08d42e3119@mail.gmail.com>
[not found] ` <alpine.DEB.1.00.1002201920350.20986@pacific.mpi-cbg.de>
2010-02-23 16:51 ` [GITK PATCH] gitk: support "gitk <tracheophyte> -- ." Johannes Schindelin
2010-02-23 17:10 ` [GITK PATCH 2/3] gitk: support path filters even in subdirectories Johannes Schindelin
2010-02-23 17:12 ` [GITK PATCH 3/3] gitk: strip prefix from filenames " Johannes Schindelin
2010-02-23 19:42 ` Kirill [this message]
2010-02-23 20:50 ` Johannes Schindelin
2010-02-23 22:20 ` Kirill
2010-02-23 19:37 ` [GITK PATCH 2/3] gitk: support path filters even " Kirill
2010-02-23 20:22 ` Johannes Schindelin
2010-02-25 1:51 ` Pat Thoyts
2010-02-25 14:22 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f579dd581002231142v6a937ac0xdc9618f2a468989d@mail.gmail.com \
--to=kirillathome@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@googlemail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).