From: Paul Smith <paul@mad-scientist.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: replace most hardcoded object lists with $(wildcard)
Date: Sat, 30 Oct 2021 19:15:14 -0400 [thread overview]
Message-ID: <f5807fd2eb0c16ab0400e8f3138a90f564fd303c.camel@mad-scientist.net> (raw)
In-Reply-To: <patch-1.1-bbacbed5c95-20211030T223011Z-avarab@gmail.com>
On Sun, 2021-10-31 at 00:32 +0200, Ævar Arnfjörð Bjarmason wrote:
> +LIB_OBJS += $(patsubst %.c,%.o,$(foreach dir,$(LIB_OBJS_DIRS),$(wildcard $(dir)/*.c)))
Another way to write this would be:
LIB_OBJS += $(patsubst %.c,%.o,$(wildcard $(addsuffix /*.c,$(LIB_OBJS_DIRS)))
I don't know that there's any reason to choose one over the other. I
don't think there's any real performance difference although one could
imagine this version to be VERY SLIGHTLY faster. Also this one is a
little more "Lisp-ish"... that might be a pro or a con depending :).
Just kibitzing while waiting for dinner to arrive...
next prev parent reply other threads:[~2021-10-30 23:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 22:32 [PATCH] Makefile: replace most hardcoded object lists with $(wildcard) Ævar Arnfjörð Bjarmason
2021-10-30 23:15 ` Paul Smith [this message]
2021-11-01 20:06 ` Ævar Arnfjörð Bjarmason
2021-10-31 8:29 ` Jeff King
2021-10-31 13:00 ` Ævar Arnfjörð Bjarmason
2021-11-03 11:30 ` Jeff King
2021-11-03 14:57 ` Ævar Arnfjörð Bjarmason
2021-11-04 0:31 ` Johannes Schindelin
2021-11-04 9:46 ` Ævar Arnfjörð Bjarmason
2021-11-04 14:29 ` Philip Oakley
2021-11-04 17:07 ` Junio C Hamano
2021-11-01 19:19 ` [PATCH v2 0/3] " Ævar Arnfjörð Bjarmason
2021-11-01 19:19 ` [PATCH v2 1/3] Makefile: rename $(SCRIPT_LIB) to $(SCRIPT_LIB_GEN) Ævar Arnfjörð Bjarmason
2021-11-01 19:19 ` [PATCH v2 2/3] Makefile: add a utility to dump variables Ævar Arnfjörð Bjarmason
2021-11-01 19:19 ` [PATCH v2 3/3] Makefile: replace most hardcoded object lists with $(wildcard) Ævar Arnfjörð Bjarmason
2021-11-06 10:57 ` Phillip Wood
2021-11-06 14:27 ` Ævar Arnfjörð Bjarmason
2021-11-06 16:49 ` Phillip Wood
2021-11-06 21:13 ` Ævar Arnfjörð Bjarmason
2021-11-09 21:38 ` Junio C Hamano
2021-11-10 12:39 ` Johannes Schindelin
2021-11-10 13:21 ` Ævar Arnfjörð Bjarmason
2021-11-10 14:59 ` Johannes Schindelin
2021-11-10 15:58 ` Ævar Arnfjörð Bjarmason
2022-01-21 12:01 ` Ævar Arnfjörð Bjarmason
2022-01-21 17:14 ` Phillip Wood
2022-01-21 18:13 ` Ævar Arnfjörð Bjarmason
2022-01-22 6:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5807fd2eb0c16ab0400e8f3138a90f564fd303c.camel@mad-scientist.net \
--to=paul@mad-scientist.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).