From: "Nuno Sá" <noname.nuno@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Erik Cervin Edin <erik@cervined.in>, git@vger.kernel.org
Subject: Re: git notes question
Date: Thu, 10 Mar 2022 09:37:18 +0100 [thread overview]
Message-ID: <f5be5b264f30f689546db3883b4b64c88ba00cb3.camel@gmail.com> (raw)
In-Reply-To: <xmqqee3bm2b8.fsf@gitster.g>
On Wed, 2022-03-09 at 10:02 -0800, Junio C Hamano wrote:
> Nuno Sá <noname.nuno@gmail.com> writes:
>
> > AFAICT, git-format-patch looks to be using --pretty=email and I
> > think
> > we can use --pretty in git-format-patch but having to mimic the
> > email
> > format "by hand" is just painful and I was hoping a better way
> > could
> > exist.
>
> Well, this time it was "Notes:" label, but the next person who
> wants to see a deviation from the canned "email" format would want a
> deviation different from yours. Perhaps they want a different way
I'm surely missing something but I'm not sure this is specific to the
email format? It's just that git-notes by default will always either
append the "Notes:" or "Notes (<refname>):" independent of the
predefined format you use. The only way to stop it from doing that is,
apparently, by using your own --format=<template>...
What I was asking was just if there was a way to not use these default
strings. I don't think this would open all kind of deviations... Either
you use these default strings or don't. But I think these strings are
probably used/important for git log? So we can know what is commit
message and what are notes...
> to format the author name? Perhaps they want a different way to
> separate the title (to be on the "Subject:" line) out of the commit
> message? Perhaps they want to see the log message be indented?
> Perhaps they want to see the message from the notes be line-wrapped?
> Perhaps they want to see the message from the notes not to be
> indented? Perhaps they want to see the "Notes (amlog):" label to
> format the name of the notes tree differently?
>
> Where would that end? We have to draw the line somewhere.
>
> The customizability via --format=<template> is given for these
> people who want to futz with that line. One thing that may be a
> good little project to help them is to make sure that the vanilla
> "--pretty=email" can be reimplemented as "--format=<template>" (I
> doubt it is), design a way to fill the gaps (if there are) to get
> there. Once that is done, write down the "--format=<template>" that
> is equivalent to "--pretty=email" somewhere in the doc, to give
> those who want to derive from the canned format some reasonable
> starting point.
Well, this would be surely nice. For now, I will just remove it by hand
or script something to do it before calling git-send-email.
Thanks for the feedback!
- Nuno Sá
next prev parent reply other threads:[~2022-03-10 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 13:08 git notes question Nuno Sá
2022-03-09 8:54 ` Erik Cervin Edin
2022-03-09 9:11 ` Nuno Sá
2022-03-09 18:02 ` Junio C Hamano
2022-03-10 8:37 ` Nuno Sá [this message]
2022-03-10 13:11 ` Erik Cervin Edin
2022-03-10 13:26 ` Nuno Sá
2022-03-10 17:52 ` Junio C Hamano
2022-03-11 9:02 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5be5b264f30f689546db3883b4b64c88ba00cb3.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=erik@cervined.in \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).