git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default
Date: Wed, 10 Jul 2024 13:46:44 +0900	[thread overview]
Message-ID: <f5d3f63c-5d17-402a-854b-edcc8708f3df@gmail.com> (raw)
In-Reply-To: <xmqq4j8xaoe7.fsf@gitster.g>

On Tue, Jul 09, 2024 at 08:58:56PM -0700, Junio C Hamano wrote:

 > > I used, more or less, the text for the message that Junio
 > > suggested.
 >
 > Hmph, the above doesn't look like any, but as a standalone patch it
 > is very much readable.

Ok.  I'll apply the simplification as a separate patch and then remove
the reference to GIT_TEST_SANITIZE_LEAK_LOG.

 > I won't be able to apply this to my tree, with
 >
 >     warning: Patch sent with format=flowed; space at the end of lines 
might be lost.
 >     error: corrupt patch at line 22
 >
 > until these get fixed,

Ouch.  My email client is set up incorrectly.  I'll fix it.
Sorry.

 > but is this meant to apply on top of 47c6d4da
 > (test-lib: fix GIT_TEST_SANITIZE_LEAK_LOG, 2024-06-30) which is
 > cooking in 'next'?

It is.  I'll use "git format-patch --base=47c6d4da" to reroll.

However, will wait a bit for confirmation that this patch is heading
in the expected direction.

Thanks.

  reply	other threads:[~2024-07-10  4:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10  0:51 [PATCH] test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default Rubén Justo
2024-07-10  1:12 ` Jeff King
2024-07-22  7:52   ` Patrick Steinhardt
2024-07-10  2:30 ` [PATCH v2] " Rubén Justo
2024-07-10  3:58   ` Junio C Hamano
2024-07-10  4:46     ` Rubén Justo [this message]
2024-07-10  7:16   ` Jeff King
2024-07-11 14:03     ` Rubén Justo
2024-07-11 14:10   ` [PATCH v3] " Rubén Justo
2024-07-17  7:02     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5d3f63c-5d17-402a-854b-edcc8708f3df@gmail.com \
    --to=rjusto@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).