From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: New cgi parameter: filter
Date: Wed, 11 Jul 2007 23:19:41 +0200 [thread overview]
Message-ID: <f73hhc$uo1$1@sea.gmane.org> (raw)
In-Reply-To: 20070708013543.GD29994@genesis.frugalware.org
[Cc: git@vger.kernel.org]
Miklos Vajna wrote:
> + ((defined $filter and $filter == "nomerges") ? ("--no-merges") : ()),
Shouldn't it be '$filter eq "nomerges"' instead?
Besides, I'd rather have generalized way to provide additional options
to git commands, like '--no-merges' for RSS and Atom feeds, log, shortlog
and history views, '-C' for commitdiff view, '--remove-empty' for history
view for a file, perhaps even '-c' or '--cc' for commitdiff for merges
instead of abusing 'hp' argument for that.
But that doesn't mean that this patch should be not applied... it doesn't
mean it should be applied neither ;-)
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2007-07-11 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 1:35 [PATCH] gitweb: New cgi parameter: filter Miklos Vajna
2007-07-09 21:18 ` VMiklos
2007-07-11 21:19 ` Jakub Narebski [this message]
2007-07-11 23:00 ` [PATCH] gitweb: new cgi parameter: option Miklos Vajna
2007-07-12 10:11 ` Jakub Narebski
2007-07-12 11:49 ` Johannes Schindelin
2007-07-12 18:39 ` [PATCH] gitweb: new cgi parameter: opt Miklos Vajna
2007-07-12 18:45 ` [PATCH] gitweb: new cgi parameter: option Junio C Hamano
2007-07-13 0:03 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f73hhc$uo1$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).