public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "Samo Pogačnik via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Patrick Steinhardt" <ps@pks.im>,
	"Samo Pogačnik" <samo_pogacnik@t-2.net>,
	"Samo Pogačnik" <samo_pogacnik@t-2.net>
Subject: [PATCH v3 1/2] shallow: free local object_array allocations
Date: Sat, 10 Jan 2026 05:13:37 +0000	[thread overview]
Message-ID: <f8a8d077cd7203663406bf656287ed7e0d6e6d90.1768022018.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2121.v3.git.git.1768022018.gitgitgadget@gmail.com>

From: =?UTF-8?q?Samo=20Poga=C4=8Dnik?= <samo_pogacnik@t-2.net>

The local object_array 'stack' in get_shallow_commits() function
does not free its dynamic elements before the function returns.
As a result elements remain allocated and their reference forgotten.

Also note, that test 'fetching deepen beyond merged branch' added by
'shallow: handling fetch relative-deepen' patch fails without this
correction in linux-leaks and linux-reftable-leaks test runs.

Signed-off-by: Samo Pogačnik <samo_pogacnik@t-2.net>
---
 shallow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/shallow.c b/shallow.c
index 55b9cd9d3f..497a25836b 100644
--- a/shallow.c
+++ b/shallow.c
@@ -198,6 +198,7 @@ struct commit_list *get_shallow_commits(struct object_array *heads, int depth,
 		}
 	}
 	deep_clear_commit_depth(&depths, free_depth_in_slab);
+	object_array_clear(&stack);
 
 	return result;
 }
-- 
gitgitgadget


  reply	other threads:[~2026-01-10  5:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 18:11 [PATCH 0/2] shallow: handling fetch relative-deepen Samo Pogačnik via GitGitGadget
2025-12-09 18:11 ` [PATCH 1/2] shallow: free local object_array allocations Samo Pogačnik via GitGitGadget
2026-01-06  7:44   ` Patrick Steinhardt
2026-01-09 16:21     ` Samo Pogačnik
2026-01-09 16:33       ` Patrick Steinhardt
2025-12-09 18:11 ` [PATCH 2/2] shallow: handling fetch relative-deepen Samo Pogačnik via GitGitGadget
2026-01-06  7:44   ` Patrick Steinhardt
2026-01-09 16:48     ` Samo Pogačnik
2026-01-09 22:23 ` [PATCH v2 0/2] " Samo Pogačnik via GitGitGadget
2026-01-09 22:23   ` [PATCH v2 1/2] shallow: free local object_array allocations Samo Pogačnik via GitGitGadget
2026-01-09 22:23   ` [PATCH v2 2/2] shallow: handling fetch relative-deepen Samo Pogačnik via GitGitGadget
2026-01-10  4:17     ` Junio C Hamano
2026-01-10  5:13   ` [PATCH v3 0/2] " Samo Pogačnik via GitGitGadget
2026-01-10  5:13     ` Samo Pogačnik via GitGitGadget [this message]
2026-01-10  5:13     ` [PATCH v3 2/2] " Samo Pogačnik via GitGitGadget
2026-01-15 15:50       ` Kristoffer Haugsbakk
2026-01-16 22:30     ` [PATCH v4 0/2] " Samo Pogačnik via GitGitGadget
2026-01-16 22:31       ` [PATCH v4 1/2] shallow: free local object_array allocations Samo Pogačnik via GitGitGadget
2026-01-16 22:31       ` [PATCH v4 2/2] shallow: handling fetch relative-deepen Samo Pogačnik via GitGitGadget
2026-02-11 13:38         ` Patrick Steinhardt
2026-02-13 20:48           ` Samo Pogačnik
2026-02-14  9:40           ` Samo Pogačnik
2026-02-15 11:19             ` Samo Pogačnik
2026-02-15 20:11       ` [PATCH v5 0/2] " Samo Pogačnik via GitGitGadget
2026-02-15 20:11         ` [PATCH v5 1/2] shallow: free local object_array allocations Samo Pogačnik via GitGitGadget
2026-02-15 20:11         ` [PATCH v5 2/2] shallow: handling fetch relative-deepen Samo Pogačnik via GitGitGadget
2026-02-20 22:34         ` [PATCH v5 0/2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8a8d077cd7203663406bf656287ed7e0d6e6d90.1768022018.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=samo_pogacnik@t-2.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox