git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joshua Hudson <jhudson@cedaron.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Null pointer dereference in error pathway on git pull
Date: Tue, 26 Jan 2021 15:01:32 -0800	[thread overview]
Message-ID: <f8b3b05a-db46-1977-6fb4-ed13ac48e131@cedaron.com> (raw)
In-Reply-To: <YBCd2ZAumP65yrUK@coredump.intra.peff.net>

2.29.2; yeah it does look like it could be the same bug

On 1/26/2021 2:55 PM, Jeff King wrote:
> On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:
>
>>> git pull
>> remote: Azure Repos
>> remote: Found 452 objects to send. (157 ms)
>> Rfatal: the remote end hung up unexpectedly
>> fatal: early EOFs:  81% (367/452)
>> fatal: index-pack failed
>> warning: unable to unlink '(NULL)': Invalid argument
>>
>>
>> So it hits some kind of error (looks like network disconnect) and tries
>> to back out; passed a NULL pointer to unlink().
>>
>> Apologies if this has been submitted before. A search didn't find it.
> Which version of Git are you using? It sounds like the same bug fixed by
> 6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).
> That's in v2.30.0.
>
> -Peff

      reply	other threads:[~2021-01-27 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 20:31 Null pointer dereference in error pathway on git pull Joshua Hudson
2021-01-26 22:55 ` Jeff King
2021-01-26 23:01   ` Joshua Hudson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8b3b05a-db46-1977-6fb4-ed13ac48e131@cedaron.com \
    --to=jhudson@cedaron.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).