From: Jon Simons <jon@jonsimons.org>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 00/15] push: speed up client-side refspec matching
Date: Sat, 10 Oct 2026 22:35:33 -0400 [thread overview]
Message-ID: <f949a5fa-5485-4ae4-a7dc-75afaef798cc@jonsimons.org> (raw)
In-Reply-To: <4fcdf05d-b558-4471-b696-bd7c285f49e2@app.fastmail.com>
On 10/9/26 4:18 PM, Kristoffer Haugsbakk wrote:
> On Fri, Oct 9, 2026, at 21:29, Jon Simons wrote:
>> Guide to changes:
>>
>> - Commits are ordered to introduce failing tests for behavioral
>> changes and bugfixes, before the code change that fixes them
>
> This project prefers introducing the
> regression test and fix in the same commit.
>
Thanks, I did not know this, and in searching I now find that this is a
common review feedback [1]. And the commit history also shows that it
is uncommon for a series to be merged that introduces a failing test
then fix in a subsequent commit.
I'll look at squashing the commits that introduce new test_expect_failure
cases up into the commits that toggles them passing, for v2, after first
letting the v1 soak for comments.
-Jon
[1] A couple examples of feedback and rationale to not to do this from
August 2025 here:
- https://lore.kernel.org/git/xmqqqzxpzo8b.fsf@gitster.g/
- https://lore.kernel.org/git/xmqqfrdk3aqy.fsf@gitster.g/
prev parent reply other threads:[~2026-10-11 2:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 19:29 [PATCH 00/15] push: speed up client-side refspec matching Jon Simons
2026-10-09 19:29 ` [PATCH 01/15] remote: validate --force-with-lease <refname> argument Jon Simons
2026-10-09 19:29 ` [PATCH 02/15] t5516: demonstrate push with "./"-prefixed source Jon Simons
2026-10-09 19:29 ` [PATCH 03/15] t5510: document fetch with "./"-prefixed branch.<name>.merge Jon Simons
2026-10-09 19:29 ` [PATCH 04/15] t/perf: add explicit delete refspec matching test Jon Simons
2026-10-09 19:29 ` [PATCH 05/15] refs: stop using mkpath() in refname_match() Jon Simons
2026-10-09 19:29 ` [PATCH 06/15] remote: use strmap for check_push_refs() Jon Simons
2026-10-09 19:29 ` [PATCH 07/15] t5516: test pushing two refspecs creating the same new branch Jon Simons
2026-10-09 19:29 ` [PATCH 08/15] t5408, t5410: test duplicate updates without relying on the client Jon Simons
2026-10-09 19:29 ` [PATCH 09/15] t5408: check refspec order with distinct destinations Jon Simons
2026-10-09 19:29 ` [PATCH 10/15] t5408: expect client-side error for duplicate destinations Jon Simons
2026-10-09 19:29 ` [PATCH 11/15] remote: reject duplicate destinations on an empty remote Jon Simons
2026-10-09 19:29 ` [PATCH 12/15] remote: use strmap for match_explicit_refs() Jon Simons
2026-10-09 19:29 ` [PATCH 13/15] t/perf: measure --force-with-lease in p5516 Jon Simons
2026-10-09 19:29 ` [PATCH 14/15] remote: restructure apply_push_cas() loops Jon Simons
2026-10-09 19:29 ` [PATCH 15/15] remote: use strmap for apply_push_cas() Jon Simons
2026-10-09 20:18 ` [PATCH 00/15] push: speed up client-side refspec matching Kristoffer Haugsbakk
2026-10-11 2:35 ` Jon Simons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f949a5fa-5485-4ae4-a7dc-75afaef798cc@jonsimons.org \
--to=jon@jonsimons.org \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox