git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kees-Jan Dijkzeul" <k.j.dijkzeul@gmail.com>
To: git@vger.kernel.org
Subject: Re: Fwd: git-svn dcommit fail
Date: Thu, 5 Jul 2007 13:06:21 +0200	[thread overview]
Message-ID: <fa0b6e200707050406i831816co80ff1500dae6bf54@mail.gmail.com> (raw)
In-Reply-To: <7v1wfndyow.fsf@assigned-by-dhcp.cox.net>

On 7/5/07, Junio C Hamano <gitster@pobox.com> wrote:
> Could you double check?

*Blush*. I should have caught that one myself. I'm now at commit
114fd812f78ea375ee6782d4ff0203f3ae20b076, which still exhibits the
same problem.

Basically, the problem is as follows: My head commit is a merge:
$ git show HEAD
commit e135f26dbae66f539b486646a12aa51e71c196a1
Merge: bb8ac98... f453e1e...

Both parents are svn-commits.

When I do a dry-run, I get
$ git-svn dcommit -n
diff-tree e135f26dbae66f539b486646a12aa51e71c196a1~1
e135f26dbae66f539b486646a12aa51e71c196a1

As far as I'm concerned, this is correct. This is the delta that
should be committed to the svn branch who's head is
e135f26dbae66f539b486646a12aa51e71c196a1~1 (obviously).

However, function "working_head_info" of git-svn returns the other
parent as the working head. As a result, committing the diff to svn
fails.

I've observed that the call to cmt_metadata("$d~1") (line 382 of
git-svn) does return the correct svn branch, so it would seem to me
that it makes much more sense to commit to that.

Any thoughts, tips, tricks?

Thanks!

Kees-Jan

  reply	other threads:[~2007-07-05 11:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04  9:56 git-svn dcommit fail Dongsheng Song
2007-07-05  7:11 ` Steven Grimm
     [not found]   ` <fa0b6e200707050126m17a23de6uad4909533306eb06@mail.gmail.com>
2007-07-05  8:28     ` Fwd: " Kees-Jan Dijkzeul
2007-07-05  8:47       ` Junio C Hamano
2007-07-05 11:06         ` Kees-Jan Dijkzeul [this message]
2007-07-05 16:18           ` Steven Grimm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa0b6e200707050406i831816co80ff1500dae6bf54@mail.gmail.com \
    --to=k.j.dijkzeul@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).