* [PATCH] t3903: fix misquoted rev-parse invocation
@ 2011-08-30 0:06 Thomas Rast
2011-08-30 1:52 ` Jon Seymour
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Rast @ 2011-08-30 0:06 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Jon Seymour
!"git ..." hopefully always succeeds because "git ..." is not the name
of any executable. However, that's not what was intended. Unquote
it, and while we're at it, also replace ! with test_must_fail since it
is a call to git.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
I kind of wonder how many bogus tests we have...
t/t3903-stash.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 7197aae..fcdb182 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -542,7 +542,7 @@ test_expect_success 'ref with non-existent reflog' '
echo bar6 > file2 &&
git add file2 &&
git stash &&
- ! "git rev-parse --quiet --verify does-not-exist" &&
+ test_must_fail git rev-parse --quiet --verify does-not-exist &&
test_must_fail git stash drop does-not-exist &&
test_must_fail git stash drop does-not-exist@{0} &&
test_must_fail git stash pop does-not-exist &&
--
1.7.7.rc0.370.gdcae57
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t3903: fix misquoted rev-parse invocation
2011-08-30 0:06 [PATCH] t3903: fix misquoted rev-parse invocation Thomas Rast
@ 2011-08-30 1:52 ` Jon Seymour
2011-08-30 18:03 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jon Seymour @ 2011-08-30 1:52 UTC (permalink / raw)
To: Thomas Rast; +Cc: Junio C Hamano, git
On Tue, Aug 30, 2011 at 10:06 AM, Thomas Rast <trast@student.ethz.ch> wrote:
>
> !"git ..." hopefully always succeeds because "git ..." is not the name
> of any executable. However, that's not what was intended. Unquote
> it, and while we're at it, also replace ! with test_must_fail since it
> is a call to git.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
Oops.
Acked-by: Jon Seymour <jon.seymour@gmail.com>
| Apologies for resend, didn't realise my gmail was sending in rich text.
jon.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t3903: fix misquoted rev-parse invocation
2011-08-30 1:52 ` Jon Seymour
@ 2011-08-30 18:03 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2011-08-30 18:03 UTC (permalink / raw)
To: Jon Seymour; +Cc: Thomas Rast, git
Thanks, both.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-30 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-30 0:06 [PATCH] t3903: fix misquoted rev-parse invocation Thomas Rast
2011-08-30 1:52 ` Jon Seymour
2011-08-30 18:03 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).