git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mathieu Liénard--Mayor" <mathieu.lienard--mayor@ensimag.fr>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Users <git@vger.kernel.org>,
	<Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: New feature discussion: git rebase --status
Date: Wed, 12 Jun 2013 12:17:23 +0200	[thread overview]
Message-ID: <fa9c12a81ef2e92ba75dd1271d9e0b2d@ensibm.imag.fr> (raw)
In-Reply-To: <CA+55aFwtBm2RPwgXNa48zQM7ONCgzOEN2XdA_MeHsGu4=BDq5w@mail.gmail.com>

After a few hours, here's a quick summary of your opinions:

-'git status' should be the command to display the information instead 
of a --status flag
-the SHA1 of the patch being applied currently is a very important 
information
-displaying how we got to this state would be nice

I had in mind a slight change in the current status message, just to 
include the SHA1 and where we're at in the rebasing. It would look like 
this:

$ git status
# HEAD detached from ecb9f3e
# You are currently editing a832578... my_commit_message [3/5] while 
rebasing.
#   (use "git commit --amend" to amend the current commit)
#   (use "git rebase --continue" once you are satisfied with your 
changes)
# ......
# ......

Now, I'm not sure if we should always display the list of commits 
already applied and those left to apply. What I mean is that maybe it 
would be better to make status require a flag to display the two lists.
Something like (not sure about the flag's name):

$ git status --rebase-state
# HEAD detached from ecb9f3e
# Already applied 2 patches:
# 	b170635... my_commit_message
# 	b170635... my_commit_message
# You are currently editing a832578... my_commit_message [3/5] while 
rebasing.
# 2 patches left to apply:
#	b170635... my_commit_message
#	b170635... my_commit_message
#   (use "git commit --amend" to amend the current commit)
#   (use "git rebase --continue" once you are satisfied with your 
changes)
# ......
# ......

What do you guys think ?

-- 
Mathieu Liénard--Mayor,
2nd year at Grenoble INP - ENSIMAG
(+33)6 80 56 30 02

  reply	other threads:[~2013-06-12 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 12:35 New feature discussion: git rebase --status Mathieu Liénard--Mayor
2013-06-11 12:40 ` Thomas Rast
2013-06-11 12:55 ` John Keeping
2013-06-11 13:19   ` Matthieu Moy
2013-06-11 17:18     ` Hilco Wijbenga
2013-06-11 17:23       ` Linus Torvalds
2013-06-12 10:17         ` Mathieu Liénard--Mayor [this message]
2013-06-12 11:12           ` Célestin Matte
2013-06-12 11:23             ` Mathieu Liénard--Mayor
2013-06-12 12:28               ` Antoine Pelisse
     [not found]                 ` <CAH_OBifOeSSWB-LPT=Zv2AGEf5+nTh7yxE-1ijD0snFp3RS8Dw@mail.gmail.com>
2013-06-12 12:50                   ` Mathieu Liénard--Mayor
2013-06-12 22:19                 ` Junio C Hamano
2013-06-13  5:52                   ` Antoine Pelisse
2013-06-13 12:19                     ` Mathieu Liénard--Mayor
2013-06-12 12:41           ` Matthieu Moy
2013-06-12 12:52             ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa9c12a81ef2e92ba75dd1271d9e0b2d@ensibm.imag.fr \
    --to=mathieu.lienard--mayor@ensimag.fr \
    --cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).