public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Jean-Noël AVILA" <jn.avila@free.fr>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] doc: interpret-trailers: convert to synopsis style
Date: Thu, 12 Mar 2026 20:11:29 +0100	[thread overview]
Message-ID: <faa89e88-42b0-4d52-993a-e4bf2937d711@app.fastmail.com> (raw)
In-Reply-To: <1953989.tdWV9SEqCh@piment-oiseau>

Thank you for the review.

On Thu, Mar 12, 2026, at 18:34, Jean-Noël AVILA wrote:
>>[snip]
>> @@ -359,8 +359,8 @@ See-also: fe3187489d69c4 (subject of related commit)
>>  * Configure a commit template with some trailers with empty values
>>    (using sed to show and keep the trailing spaces at the end of the
>>    trailers), then configure a commit-msg hook that uses
>> -  'git interpret-trailers' to remove trailers with empty values and
>> -  to add a 'git-version' trailer:
>> +  linkgit:git-interpret-trailers[1] to remove trailers with empty values
>
> We are already in the manual page of git-interpret-trailer. It is useless to
> provide a link to the current manpage.
>

What should be written here? The existing `git interpret-trailers` or
git-interpret-trailers(1)?

>> and
>> +  to add a `git-version` trailer:
>>  +
>>  ------------
>>  $ cat temp.txt

I’ll incorporate all of these in the next round.

  reply	other threads:[~2026-03-12 19:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 22:31 [PATCH 0/3] doc: interpret-trailers: convert to synopsis and update options kristofferhaugsbakk
2026-03-11 22:31 ` [PATCH 1/3] doc: interpret-trailers: convert to synopsis style kristofferhaugsbakk
2026-03-12  1:38   ` Junio C Hamano
2026-03-13 16:43     ` Kristoffer Haugsbakk
2026-03-12 17:34   ` Jean-Noël AVILA
2026-03-12 19:11     ` Kristoffer Haugsbakk [this message]
2026-03-11 22:31 ` [PATCH 2/3] doc: interpret-trailers: normalize and fill out options kristofferhaugsbakk
2026-03-11 22:31 ` [PATCH 3/3] doc: config: convert trailers section to synopsis style kristofferhaugsbakk
2026-03-12 17:48   ` Jean-Noël AVILA
2026-03-12 18:14     ` Junio C Hamano
2026-03-12  0:51 ` [PATCH 0/3] doc: interpret-trailers: convert to synopsis and update options Junio C Hamano
2026-03-12  0:53   ` Kristoffer Haugsbakk
2026-03-16 21:48 ` [PATCH v2 0/4] " kristofferhaugsbakk
2026-03-16 21:48   ` [PATCH v2 1/4] doc: interpret-trailers: convert to synopsis style kristofferhaugsbakk
2026-03-16 21:48   ` [PATCH v2 2/4] doc: interpret-trailers: normalize and fill out options kristofferhaugsbakk
2026-03-16 21:48   ` [PATCH v2 3/4] doc: config: convert trailers section to synopsis style kristofferhaugsbakk
2026-03-16 21:48   ` [PATCH v2 4/4] interpret-trailers: use placeholder instead of * kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=faa89e88-42b0-4d52-993a-e4bf2937d711@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox