pre-commit hook

pre-commit hook

[bill lam]

The pre-commit hooks as follows.

 10 # This is slightly modified from Andrew Morton's Perfect Patch.
 11 # Lines you introduce should not have trailing whitespace.
 12 # Also check for an indentation that has SP before a TAB.
 13 
 14 if git-rev-parse --verify HEAD 2>/dev/null
 15 then
 16   git-diff-index -p -M --cached HEAD --
 17 else
 18   # NEEDSWORK: we should produce a diff with an empty tree here
 19   # if we want to do the same verification for the initial import.
 20   :                                                                                                                        
 21 fi |
 22 perl -e '

Will it also include binary files and thus corrupt data? And
"git-rev-parse" should already deprecated.

-- 
regards,
====================================================
GPG key 1024D/4434BAB3 2008-08-24
gpg --keyserver subkeys.pgp.net --recv-keys 4434BAB3
唐詩232 孟浩然  春曉
    春眠不覺曉  處處聞啼鳥  夜來風雨聲  花落知多少

Re: pre-commit hook

[Junio C Hamano]

bill lam <cbill.lam@gmail.com> writes:

> The pre-commit hooks as follows.
>
>  10 # This is slightly modified from Andrew Morton's Perfect Patch.
>  11 # Lines you introduce should not have trailing whitespace.

That's a sample hook from an ancient version of git.  We do not ship that
version anymore since late last June.  You should be able to replace it
with the version shipped with v1.6.0 or later if your git is recent
enough.

    #!/bin/sh
    #
    # An example hook script to verify what is about to be committed.
    # Called by git-commit with no arguments.  The hook should
    # exit with non-zero status after issuing an appropriate message if
    # it wants to stop the commit.
    #
    # To enable this hook, rename this file to "pre-commit".

    if git-rev-parse --verify HEAD 2>/dev/null
    then
            against=HEAD
    else
            # Initial commit: diff against an empty tree object
            against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
    fi

    exec git diff-index --check --cached $against --

Perhaps a time to upgrade?  People should be running at least 1.6.0 these
days ;-).

Re: pre-commit hook

[bill lam]

On Fri, 20 Feb 2009, Junio C Hamano wrote:
>     if git-rev-parse --verify HEAD 2>/dev/null

Isn't git-rev-parse (and all git-??? ) was deprecated in 1.6.2 ?

-- 
regards,
====================================================
GPG key 1024D/4434BAB3 2008-08-24
gpg --keyserver subkeys.pgp.net --recv-keys 4434BAB3
唐詩311 無名氏  雜詩
    盡寒食雨草萋萋  著麥苗風柳映堤  等是有家歸未得  杜鵑休向耳邊啼

Re: pre-commit hook

[Michael J Gruber]

bill lam venit, vidit, dixit 21.02.2009 04:57:
> On Fri, 20 Feb 2009, Junio C Hamano wrote:
>>     if git-rev-parse --verify HEAD 2>/dev/null
> 
> Isn't git-rev-parse (and all git-??? ) was deprecated in 1.6.2 ?
> 

It's OK in hooks because the path is set appropriately there.

Michael

Re: pre-commit hook

[bill lam]

On Sat, 21 Feb 2009, Michael J Gruber wrote:
> > Isn't git-rev-parse (and all git-??? ) was deprecated in 1.6.2 ?
> > 
> 
> It's OK in hooks because the path is set appropriately there.

I make and install with prefix=/usr/bin , however I can only find git
inside /usr/bin; other git-???? are missing although they are built.
"which git-rev-parse" return nothing but "git rev-parse" can work.
Where are these git commands stored and how does the git locate them ?
 
-- 
regards,
====================================================
GPG key 1024D/4434BAB3 2008-08-24
gpg --keyserver subkeys.pgp.net --recv-keys 4434BAB3
唐詩169 僧皎然  尋陸鴻漸不遇
    移家雖帶郭  野徑入桑麻  近種籬邊菊  秋來未著花
    扣門無犬吠  欲去問西家  報到山中去  歸來每日斜

Re: pre-commit hook

[Sverre Rabbelier]

2009/2/22 bill lam <cbill.lam@gmail.com>:
> I make and install with prefix=/usr/bin , however I can only find git
> inside /usr/bin; other git-???? are missing although they are built.
> "which git-rev-parse" return nothing but "git rev-parse" can work.
> Where are these git commands stored and how does the git locate them ?

Have a look at the output of `git --exec-path`.

-- 
Cheers,

Sverre Rabbelier

Re: pre-commit hook

[bill lam]

On Sun, 22 Feb 2009, Sverre Rabbelier wrote:
> Have a look at the output of `git --exec-path`.

Thanks, Sverre.

-- 
regards,
====================================================
GPG key 1024D/4434BAB3 2008-08-24
gpg --keyserver subkeys.pgp.net --recv-keys 4434BAB3
唐詩021 王昌齡  同從弟南齋翫月憶山陰崔少府
    高臥南齋時  開帷月初吐  清輝淡水木  演漾在窗戶  苒苒幾盈虛  澄澄變今古
    美人清江畔  是夜越吟苦  千里其如何  微風吹蘭杜